diff options
Diffstat (limited to 'clang/test')
| -rw-r--r-- | clang/test/Parser/objc-available.m | 2 | ||||
| -rw-r--r-- | clang/test/Sema/attr-availability.c | 2 | ||||
| -rw-r--r-- | clang/test/SemaObjC/attr-availability.m | 14 | ||||
| -rw-r--r-- | clang/test/SemaObjC/property-deprecated-warning.m | 20 | ||||
| -rw-r--r-- | clang/test/SemaObjC/unguarded-availability.m | 180 |
5 files changed, 198 insertions, 20 deletions
diff --git a/clang/test/Parser/objc-available.m b/clang/test/Parser/objc-available.m index ca307531443..d18ac1f1344 100644 --- a/clang/test/Parser/objc-available.m +++ b/clang/test/Parser/objc-available.m @@ -15,8 +15,6 @@ void f() { (void)@available(erik_os 10.10, hat_os 1.0, *); // expected-error 2 {{unrecognized platform name}} - (void)@available(ios 8, *); // expected-warning{{using '*' case here, platform macos is not accounted for}} - (void)@available(); // expected-error{{expected a platform name here}} (void)@available(macos 10.10,); // expected-error{{expected a platform name here}} (void)@available(macos); // expected-error{{expected a version}} diff --git a/clang/test/Sema/attr-availability.c b/clang/test/Sema/attr-availability.c index 8fe6be3804e..a4b40ff9e0c 100644 --- a/clang/test/Sema/attr-availability.c +++ b/clang/test/Sema/attr-availability.c @@ -30,7 +30,7 @@ void test_10095131() { ATSFontGetPostScriptName(100); // expected-error {{'ATSFontGetPostScriptName' is unavailable: obsoleted in macOS 9.0 - use ATSFontGetFullPostScriptName}} #if defined(WARN_PARTIAL) - // expected-warning@+2 {{is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'PartiallyAvailable' to silence this warning}} + // expected-warning@+2 {{is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'PartiallyAvailable' in an @available check to silence this warning}} #endif PartiallyAvailable(); } diff --git a/clang/test/SemaObjC/attr-availability.m b/clang/test/SemaObjC/attr-availability.m index dfd544ba025..02b7c5c8149 100644 --- a/clang/test/SemaObjC/attr-availability.m +++ b/clang/test/SemaObjC/attr-availability.m @@ -46,16 +46,16 @@ void f(A *a, B *b) { [b proto_method]; // expected-warning{{'proto_method' is deprecated: first deprecated in macOS 10.2}} #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'partialMethod' is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'partialMethod' to silence this warning}} + // expected-warning@+2 {{'partialMethod' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partialMethod' in an @available check to silence this warning}} #endif [a partialMethod]; [b partialMethod]; // no warning #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'partial_proto_method' is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'partial_proto_method' to silence this warning}} + // expected-warning@+2 {{'partial_proto_method' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partial_proto_method' in an @available check to silence this warning}} #endif [a partial_proto_method]; #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'partial_proto_method' is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'partial_proto_method' to silence this warning}} + // expected-warning@+2 {{'partial_proto_method' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'partial_proto_method' in an @available check to silence this warning}} #endif [b partial_proto_method]; } @@ -163,14 +163,14 @@ void partialfun(PartialI* a) { [a partialMethod]; // no warning [a ipartialMethod1]; // no warning #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'ipartialMethod2' is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'ipartialMethod2' to silence this warning}} + // expected-warning@+2 {{'ipartialMethod2' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'ipartialMethod2' in an @available check to silence this warning}} #endif [a ipartialMethod2]; [a ppartialMethod]; // no warning [PartialI partialMethod]; // no warning [PartialI ipartialMethod1]; // no warning #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'ipartialMethod2' is partial: introduced in macOS 10.8}} expected-note@+2 {{explicitly redeclare 'ipartialMethod2' to silence this warning}} + // expected-warning@+2 {{'ipartialMethod2' is only available on macOS 10.8 or newer}} expected-note@+2 {{enclose 'ipartialMethod2' in an @available check to silence this warning}} #endif [PartialI ipartialMethod2]; [PartialI ppartialMethod]; // no warning @@ -309,7 +309,7 @@ __attribute__((objc_root_class)) @end @implementation LookupAvailabilityBase --(void)method1 { fn_10_7(); } // expected-warning{{partial}} expected-note{{explicitly redeclare}} +-(void)method1 { fn_10_7(); } // expected-warning{{only available on macOS 10.7}} expected-note{{@available}} @end __attribute__((availability(macosx, introduced=10.7))) @@ -321,7 +321,7 @@ __attribute__((availability(macosx, introduced=10.7))) @implementation LookupAvailability -(void)method2 { fn_10_7(); } --(void)method3 { fn_10_8(); } // expected-warning{{partial}} expected-note{{explicitly redeclare}} +-(void)method3 { fn_10_8(); } // expected-warning{{only available on macOS 10.8}} expected-note{{@available}} -(void)method4 { fn_10_8(); } @end diff --git a/clang/test/SemaObjC/property-deprecated-warning.m b/clang/test/SemaObjC/property-deprecated-warning.m index cec376838de..8cf4f9731bc 100644 --- a/clang/test/SemaObjC/property-deprecated-warning.m +++ b/clang/test/SemaObjC/property-deprecated-warning.m @@ -9,7 +9,7 @@ typedef signed char BOOL; @property(nonatomic,assign) id ptarget __attribute__((availability(ios,introduced=2.0,deprecated=3.0))); // expected-note {{property 'ptarget' is declared deprecated here}} expected-note {{'ptarget' has been explicitly marked deprecated here}} #if defined(WARN_PARTIAL) -// expected-note@+2 {{property 'partialPtarget' is declared partial here}} expected-note@+2 {{'partialPtarget' has been explicitly marked partial here}} +// expected-note@+2 {{'partialPtarget' has been explicitly marked partial here}} #endif @property(nonatomic,assign) id partialPtarget __attribute__((availability(ios,introduced=5.0))); @end @@ -24,7 +24,7 @@ typedef signed char BOOL; @property(nonatomic,assign) id target __attribute__((availability(ios,introduced=2.0,deprecated=3.0))); // expected-note {{property 'target' is declared deprecated here}} expected-note {{'setTarget:' has been explicitly marked deprecated here}} #if defined(WARN_PARTIAL) -// expected-note@+2 {{property 'partialTarget' is declared partial here}} expected-note@+2 {{'setPartialTarget:' has been explicitly marked partial here}} +// expected-note@+2 {{'setPartialTarget:' has been explicitly marked partial here}} #endif @property(nonatomic,assign) id partialTarget __attribute__((availability(ios,introduced=5.0))); @end @@ -40,7 +40,7 @@ typedef signed char BOOL; // expected-note 2 {{'setDep_target:' has been explicitly marked deprecated here}} #if defined(WARN_PARTIAL) -// expected-note@+2 4 {{property 'partial_dep_target' is declared partial here}} expected-note@+2 2 {{'partial_dep_target' has been explicitly marked partial here}} expected-note@+2 2 {{'setPartial_dep_target:' has been explicitly marked partial here}} +// expected-note@+2 2 {{'partial_dep_target' has been explicitly marked partial here}} expected-note@+2 2 {{'setPartial_dep_target:' has been explicitly marked partial here}} #endif @property(nonatomic,assign) id partial_dep_target __attribute__((availability(ios,introduced=5.0))); @end @@ -57,7 +57,7 @@ typedef signed char BOOL; [self setPtarget: (id)0]; // no-warning [self setPartialTarget: (id)0]; // no-warning #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'partial_dep_target' is partial: introduced in iOS 5.0}} expected-warning@+2 {{'setPartial_dep_target:' is partial: introduced in iOS 5.0}} expected-note@+2 {{explicitly redeclare 'partial_dep_target' to silence this warning}} expected-note@+2 {{explicitly redeclare 'setPartial_dep_target:' to silence this warning}} + // expected-warning@+2 {{'partial_dep_target' is only available on iOS 5.0 or newer}} expected-warning@+2 {{'setPartial_dep_target:' is only available on iOS 5.0 or newer}} expected-note@+2 {{enclose 'partial_dep_target' in an @available check to silence this warning}} expected-note@+2 {{enclose 'setPartial_dep_target:' in an @available check to silence this warning}} #endif [self setPartial_dep_target: [self partial_dep_target]]; @@ -82,11 +82,11 @@ typedef signed char BOOL; [self setPtarget: (id)0]; // no-warning #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'setPartialTarget:' is partial: introduced in iOS 5.0}} expected-note@+2 {{explicitly redeclare 'setPartialTarget:' to silence this warning}} + // expected-warning@+2 {{'setPartialTarget:' is only available on iOS 5.0 or newer}} expected-note@+2 {{enclose 'setPartialTarget:' in an @available check to silence this warning}} #endif [self setPartialTarget: (id)0]; #if defined(WARN_PARTIAL) - // expected-warning@+2 {{'partial_dep_target' is partial: introduced in iOS 5.0}} expected-warning@+2 {{'setPartial_dep_target:' is partial: introduced in iOS 5.0}} expected-note@+2 {{explicitly redeclare 'partial_dep_target' to silence this warning}} expected-note@+2 {{explicitly redeclare 'setPartial_dep_target:' to silence this warning}} + // expected-warning@+2 {{'partial_dep_target' is only available on iOS 5.0 or newer}} expected-warning@+2 {{'setPartial_dep_target:' is only available on iOS 5.0 or newer}} expected-note@+2 {{enclose 'partial_dep_target' in an @available check to silence this warning}} expected-note@+2 {{enclose 'setPartial_dep_target:' in an @available check to silence this warning}} #endif [self setPartial_dep_target: [self partial_dep_target]]; [self setPartialPtarget: (id)0]; // no-warning @@ -100,12 +100,12 @@ typedef signed char BOOL; @property(setter=setNewDelegate:,assign) id delegate __attribute__((availability(ios,introduced=2.0,deprecated=3.0))); // expected-note {{'setNewDelegate:' has been explicitly marked deprecated here}} expected-note {{property 'delegate' is declared deprecated here}} #if defined(WARN_PARTIAL) -// expected-note@+2 {{property 'partialEnabled' is declared partial here}} expected-note@+2 {{'partialIsEnabled' has been explicitly marked partial here}} +// expected-note@+2 {{'partialIsEnabled' has been explicitly marked partial here}} #endif @property(getter=partialIsEnabled,assign) BOOL partialEnabled __attribute__((availability(ios,introduced=5.0))); #if defined(WARN_PARTIAL) -// expected-note@+2 {{property 'partialDelegate' is declared partial here}} expected-note@+2 {{'partialSetNewDelegate:' has been explicitly marked partial here}} +// expected-note@+2 {{'partialSetNewDelegate:' has been explicitly marked partial here}} #endif @property(setter=partialSetNewDelegate:,assign) id partialDelegate __attribute__((availability(ios,introduced=5.0))); @end @@ -115,7 +115,7 @@ void testCustomAccessorNames(CustomAccessorNames *obj) { [obj setNewDelegate:0]; // expected-warning {{'setNewDelegate:' is deprecated: first deprecated in iOS 3.0}} #if defined(WARN_PARTIAL) -// expected-warning@+2 {{'partialIsEnabled' is partial: introduced in iOS 5.0}} expected-warning@+3 {{'partialSetNewDelegate:' is partial: introduced in iOS 5.0}} expected-note@+2 {{explicitly redeclare 'partialIsEnabled' to silence this warning}} expected-note@+3 {{explicitly redeclare 'partialSetNewDelegate:' to silence this warning}} + // expected-warning@+2 {{'partialIsEnabled' is only available on iOS 5.0 or newer}} expected-warning@+3 {{'partialSetNewDelegate:' is only available on iOS 5.0 or newer}} expected-note@+2 {{enclose 'partialIsEnabled' in an @available check to silence this warning}} expected-note@+3 {{enclose 'partialSetNewDelegate:' in an @available check to silence this warning}} #endif if ([obj partialIsEnabled]) [obj partialSetNewDelegate:0]; @@ -138,7 +138,7 @@ id useDeprecatedProperty(ProtocolInCategory *obj, id<P> obj2, int flag) { if (flag) return [obj partialPtarget]; // no-warning #if defined(WARN_PARTIAL) -// expected-warning@+2 {{'partialPtarget' is partial: introduced in iOS 5.0}} expected-note@+2 {{explicitly redeclare 'partialPtarget' to silence this warning}} +// expected-warning@+2 {{'partialPtarget' is only available on iOS 5.0 or newer}} expected-note@+2 {{enclose 'partialPtarget' in an @available check to silence this warning}} #endif return [obj2 partialPtarget]; } diff --git a/clang/test/SemaObjC/unguarded-availability.m b/clang/test/SemaObjC/unguarded-availability.m new file mode 100644 index 00000000000..fe25c8bb146 --- /dev/null +++ b/clang/test/SemaObjC/unguarded-availability.m @@ -0,0 +1,180 @@ +// RUN: %clang_cc1 -triple x86_64-apple-macosx-10.9 -Wunguarded-availability -fblocks -fsyntax-only -verify %s +// RUN: %clang_cc1 -xobjective-c++ -DOBJCPP -triple x86_64-apple-macosx-10.9 -Wunguarded-availability -fblocks -fsyntax-only -verify %s + +#define AVAILABLE_10_0 __attribute__((availability(macos, introduced = 10.0))) +#define AVAILABLE_10_11 __attribute__((availability(macos, introduced = 10.11))) +#define AVAILABLE_10_12 __attribute__((availability(macos, introduced = 10.12))) + +int func_10_11() AVAILABLE_10_11; // expected-note 4 {{'func_10_11' has been explicitly marked partial here}} + +#ifdef OBJCPP +// expected-note@+2 {{marked partial here}} +#endif +int func_10_12() AVAILABLE_10_12; // expected-note 5 {{'func_10_12' has been explicitly marked partial here}} + +int func_10_0() AVAILABLE_10_0; + +void use_func() { + func_10_11(); // expected-warning{{'func_10_11' is only available on macOS 10.11 or newer}} expected-note{{enclose 'func_10_11' in an @available check to silence this warning}} + + if (@available(macos 10.11, *)) + func_10_11(); + else + func_10_11(); // expected-warning{{'func_10_11' is only available on macOS 10.11 or newer}} expected-note{{enclose 'func_10_11' in an @available check to silence this warning}} +} + +void defn_10_11() AVAILABLE_10_11; + +void defn_10_11() { + func_10_11(); +} + +void nested_ifs() { + if (@available(macos 10.12, *)) { + if (@available(macos 10.10, *)) { + func_10_12(); + } else { + func_10_12(); + } + } else { + func_10_12(); // expected-warning{{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{enclose 'func_10_12' in an @available check to silence this warning}} + } +} + +void star_case() { + if (@available(ios 9, *)) { + func_10_11(); // expected-warning{{'func_10_11' is only available on macOS 10.11 or newer}} expected-note{{enclose 'func_10_11' in an @available check to silence this warning}} + func_10_0(); + } else + func_10_11(); // expected-warning{{'func_10_11' is only available on macOS 10.11 or newer}} expected-note{{enclose 'func_10_11' in an @available check to silence this warning}} + + if (@available(macos 10.11, *)) { + if (@available(ios 8, *)) { + func_10_11(); + func_10_12(); // expected-warning{{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{enclose}} + } else { + func_10_11(); + func_10_12(); // expected-warning{{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{enclose}} + } + } +} + +typedef int int_10_11 AVAILABLE_10_11; // expected-note {{'int_10_11' has been explicitly marked partial here}} +#ifdef OBJCPP +// expected-note@+2 {{marked partial here}} +#endif +typedef int int_10_12 AVAILABLE_10_12; // expected-note 3 {{'int_10_12' has been explicitly marked partial here}} + +void use_typedef() { + int_10_11 x; // expected-warning{{'int_10_11' is only available on macOS 10.11 or newer}} expected-note{{enclose 'int_10_11' in an @available check to silence this warning}} +} + +__attribute__((objc_root_class)) +AVAILABLE_10_11 @interface Class_10_11 { + int_10_11 foo; + int_10_12 bar; // expected-warning {{'int_10_12' is partial: introduced in macOS 10.12}} expected-note{{redeclare}} +} +- (void)method1; +- (void)method2; +@end + +@implementation Class_10_11 +- (void) method1 { + func_10_11(); + func_10_12(); // expected-warning{{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{enclose 'func_10_12' in an @available check to silence this warning}} +} + +- (void)method2 AVAILABLE_10_12 { + func_10_12(); +} + +@end + +int protected_scope() { + if (@available(macos 10.20, *)) { // expected-note 2 {{jump enters controlled statement of if available}} + label1: + return 0; + } else { + label2: + goto label1; // expected-error{{cannot jump from this goto statement to its label}} + } + + goto label2; // expected-error{{cannot jump from this goto statement to its label}} +} + +struct S { + int m1; + int m2 __attribute__((availability(macos, introduced = 10.12))); // expected-note{{marked partial here}} + + struct Nested { + int nested_member __attribute__((availability(macos, introduced = 10.12))); // expected-note{{marked partial here}} + } n; +}; + +int test_members() { + struct S s; + (void)s.m1; + (void)s.m2; // expected-warning{{'m2' is only available on macOS 10.12 or newer}} expected-note{{@available}} + + (void)s.n.nested_member; // expected-warning{{'nested_member' is only available on macOS 10.12 or newer}} expected-note{{@available}} +} + +void test_blocks() { + (void) ^{ + func_10_12(); // expected-warning{{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{@available}} + }; +} + +void test_params(int_10_12 x); // expected-warning {{'int_10_12' is partial: introduced in macOS 10.12}} expected-note{{redeclare}} + +// FIXME: This should be fine! +void test_params2(int_10_12 x) AVAILABLE_10_12; // expected-warning {{'int_10_12' is partial: introduced in macOS 10.12}} expected-note{{redeclare}} + +#ifdef OBJCPP + +int f(char) AVAILABLE_10_12; +int f(int); + +template <class T> int use_f() { + // FIXME: We should warn here! + return f(T()); +} + +int a = use_f<int>(); +int b = use_f<char>(); + +template <class> int use_at_available() { + if (@available(macos 10.12, *)) + return func_10_12(); + else + return func_10_12(); // expected-warning {{'func_10_12' is only available on macOS 10.12 or newer}} expected-note{{enclose}} +} + +int instantiate_template() { + if (@available(macos 10.12, *)) { + use_at_available<char>(); + } else { + use_at_available<float>(); + } +} + +template <class> +int with_availability_attr() AVAILABLE_10_11 { // expected-note 2 {{marked partial here}} + return 0; +} + +int instantiate_with_availability_attr() { + if (@available(macos 10.12, *)) + with_availability_attr<char>(); + else + with_availability_attr<int>(); // expected-warning {{'with_availability_attr<int>' is only available on macOS 10.11 or newer}} expected-note {{enclose}} +} + +int instantiate_availability() { + if (@available(macos 10.12, *)) + with_availability_attr<int_10_12>(); + else + with_availability_attr<int_10_12>(); // expected-warning{{'with_availability_attr<int>' is only available on macOS 10.11 or newer}} expected-warning{{'int_10_12' is only available on macOS 10.12 or newer}} expected-note 2 {{enclose}} +} + +#endif |

