diff options
Diffstat (limited to 'clang/lib/CodeGen')
-rw-r--r-- | clang/lib/CodeGen/CGRTTI.cpp | 6 | ||||
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 16 |
2 files changed, 13 insertions, 9 deletions
diff --git a/clang/lib/CodeGen/CGRTTI.cpp b/clang/lib/CodeGen/CGRTTI.cpp index 9f3571ee63d..6e57f90e99f 100644 --- a/clang/lib/CodeGen/CGRTTI.cpp +++ b/clang/lib/CodeGen/CGRTTI.cpp @@ -355,10 +355,10 @@ static llvm::GlobalVariable::LinkageTypes getTypeInfoLinkage(QualType Ty) { return CodeGenModule::getVTableLinkage(RD); } - return llvm::GlobalValue::WeakODRLinkage; + return llvm::GlobalValue::LinkOnceODRLinkage; } - return llvm::GlobalValue::WeakODRLinkage; + return llvm::GlobalValue::LinkOnceODRLinkage; } // CanUseSingleInheritance - Return whether the given record decl has a "single, @@ -640,7 +640,7 @@ llvm::Constant *RTTIBuilder::BuildTypeInfo(QualType Ty, bool Force) { /*ForRTTI*/ true, /*ForDefinition*/ true); else if (Hidden || (CGM.getCodeGenOpts().HiddenWeakVTables && - Linkage == llvm::GlobalValue::WeakODRLinkage)) { + Linkage == llvm::GlobalValue::LinkOnceODRLinkage)) { GV->setVisibility(llvm::GlobalValue::HiddenVisibility); } GV->setUnnamedAddr(true); diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 631c3357286..ae61661da63 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -210,7 +210,7 @@ void CodeGenModule::setTypeVisibility(llvm::GlobalValue *GV, // in CGVTables.cpp. // Preconditions. - if (GV->getLinkage() != llvm::GlobalVariable::WeakODRLinkage || + if (GV->getLinkage() != llvm::GlobalVariable::LinkOnceODRLinkage || GV->getVisibility() != llvm::GlobalVariable::DefaultVisibility) return; @@ -1053,19 +1053,21 @@ CodeGenModule::getVTableLinkage(const CXXRecordDecl *RD) { case TSK_Undeclared: case TSK_ExplicitSpecialization: if (KeyFunction->isInlined()) - return llvm::GlobalVariable::WeakODRLinkage; + return llvm::GlobalVariable::LinkOnceODRLinkage; return llvm::GlobalVariable::ExternalLinkage; case TSK_ImplicitInstantiation: + return llvm::GlobalVariable::LinkOnceODRLinkage; + case TSK_ExplicitInstantiationDefinition: return llvm::GlobalVariable::WeakODRLinkage; - + case TSK_ExplicitInstantiationDeclaration: // FIXME: Use available_externally linkage. However, this currently // breaks LLVM's build due to undefined symbols. // return llvm::GlobalVariable::AvailableExternallyLinkage; - return llvm::GlobalVariable::WeakODRLinkage; + return llvm::GlobalVariable::LinkOnceODRLinkage; } } @@ -1073,6 +1075,8 @@ CodeGenModule::getVTableLinkage(const CXXRecordDecl *RD) { case TSK_Undeclared: case TSK_ExplicitSpecialization: case TSK_ImplicitInstantiation: + return llvm::GlobalVariable::LinkOnceODRLinkage; + case TSK_ExplicitInstantiationDefinition: return llvm::GlobalVariable::WeakODRLinkage; @@ -1080,11 +1084,11 @@ CodeGenModule::getVTableLinkage(const CXXRecordDecl *RD) { // FIXME: Use available_externally linkage. However, this currently // breaks LLVM's build due to undefined symbols. // return llvm::GlobalVariable::AvailableExternallyLinkage; - return llvm::GlobalVariable::WeakODRLinkage; + return llvm::GlobalVariable::LinkOnceODRLinkage; } // Silence GCC warning. - return llvm::GlobalVariable::WeakODRLinkage; + return llvm::GlobalVariable::LinkOnceODRLinkage; } CharUnits CodeGenModule::GetTargetTypeStoreSize(const llvm::Type *Ty) const { |