diff options
Diffstat (limited to 'clang-tools-extra')
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp | 3 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt | 1 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp (renamed from clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.cpp) | 4 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.h (renamed from clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.h) | 12 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/CMakeLists.txt | 1 | ||||
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp | 2 | ||||
-rw-r--r-- | clang-tools-extra/docs/ReleaseNotes.rst | 3 | ||||
-rw-r--r-- | clang-tools-extra/docs/clang-tidy/checks/bugprone-dangling-handle.rst (renamed from clang-tools-extra/docs/clang-tidy/checks/misc-dangling-handle.rst) | 6 | ||||
-rw-r--r-- | clang-tools-extra/docs/clang-tidy/checks/list.rst | 2 | ||||
-rw-r--r-- | clang-tools-extra/test/clang-tidy/bugprone-dangling-handle.cpp (renamed from clang-tools-extra/test/clang-tidy/misc-dangling-handle.cpp) | 6 |
10 files changed, 22 insertions, 18 deletions
diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp index 0506c0e4a31..e96dc812f84 100644 --- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp @@ -12,6 +12,7 @@ #include "../ClangTidyModuleRegistry.h" #include "ArgumentCommentCheck.h" #include "CopyConstructorInitCheck.h" +#include "DanglingHandleCheck.h" #include "IntegerDivisionCheck.h" #include "MisplacedOperatorInStrlenInAllocCheck.h" #include "StringConstructorCheck.h" @@ -29,6 +30,8 @@ public: "bugprone-argument-comment"); CheckFactories.registerCheck<CopyConstructorInitCheck>( "bugprone-copy-constructor-init"); + CheckFactories.registerCheck<DanglingHandleCheck>( + "bugprone-dangling-handle"); CheckFactories.registerCheck<IntegerDivisionCheck>( "bugprone-integer-division"); CheckFactories.registerCheck<MisplacedOperatorInStrlenInAllocCheck>( diff --git a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt index 0ee554c9344..fe9b999b619 100644 --- a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt @@ -4,6 +4,7 @@ add_clang_library(clangTidyBugproneModule ArgumentCommentCheck.cpp BugproneTidyModule.cpp CopyConstructorInitCheck.cpp + DanglingHandleCheck.cpp IntegerDivisionCheck.cpp MisplacedOperatorInStrlenInAllocCheck.cpp StringConstructorCheck.cpp diff --git a/clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp index 86220f41502..5388684ad36 100644 --- a/clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp @@ -18,7 +18,7 @@ using namespace clang::tidy::matchers; namespace clang { namespace tidy { -namespace misc { +namespace bugprone { namespace { @@ -179,6 +179,6 @@ void DanglingHandleCheck::check(const MatchFinder::MatchResult &Result) { << Handle->getQualifiedNameAsString(); } -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang diff --git a/clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.h b/clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.h index 48797a41d83..add8d427da2 100644 --- a/clang-tools-extra/clang-tidy/misc/DanglingHandleCheck.h +++ b/clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.h @@ -7,20 +7,20 @@ // //===----------------------------------------------------------------------===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H #include "../ClangTidy.h" namespace clang { namespace tidy { -namespace misc { +namespace bugprone { /// Detect dangling references in value handlers like /// std::experimental::string_view. /// /// For the user-facing documentation see: -/// http://clang.llvm.org/extra/clang-tidy/checks/misc-dangling-handle.html +/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-dangling-handle.html class DanglingHandleCheck : public ClangTidyCheck { public: DanglingHandleCheck(StringRef Name, ClangTidyContext *Context); @@ -36,8 +36,8 @@ private: const ast_matchers::internal::Matcher<RecordDecl> IsAHandle; }; -} // namespace misc +} // namespace bugprone } // namespace tidy } // namespace clang -#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt index c1009ba56b1..f67c1365949 100644 --- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt @@ -7,7 +7,6 @@ add_clang_library(clangTidyMiscModule MisplacedConstCheck.cpp UnconventionalAssignOperatorCheck.cpp BoolPointerImplicitConversionCheck.cpp - DanglingHandleCheck.cpp DefinitionsInHeadersCheck.cpp FoldInitTypeCheck.cpp ForwardDeclarationNamespaceCheck.cpp diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp index 11b946f5314..fbc999f2a0a 100644 --- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp @@ -12,7 +12,6 @@ #include "../ClangTidyModuleRegistry.h" #include "AssertSideEffectCheck.h" #include "BoolPointerImplicitConversionCheck.h" -#include "DanglingHandleCheck.h" #include "DefinitionsInHeadersCheck.h" #include "FoldInitTypeCheck.h" #include "ForwardDeclarationNamespaceCheck.h" @@ -73,7 +72,6 @@ public: "misc-unconventional-assign-operator"); CheckFactories.registerCheck<BoolPointerImplicitConversionCheck>( "misc-bool-pointer-implicit-conversion"); - CheckFactories.registerCheck<DanglingHandleCheck>("misc-dangling-handle"); CheckFactories.registerCheck<DefinitionsInHeadersCheck>( "misc-definitions-in-headers"); CheckFactories.registerCheck<FoldInitTypeCheck>("misc-fold-init-type"); diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index f2bbb57181f..2e143dea204 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -57,6 +57,9 @@ The improvements are... Improvements to clang-tidy -------------------------- +- The 'misc-dangling-handle' check was renamed to `bugprone-dangling-handle + <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-dangling-handle.html>`_ + - The 'misc-argument-comment' check was renamed to `bugprone-argument-comment <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html>`_ diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc-dangling-handle.rst b/clang-tools-extra/docs/clang-tidy/checks/bugprone-dangling-handle.rst index 03d03ed994a..8c2c316c090 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/misc-dangling-handle.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/bugprone-dangling-handle.rst @@ -1,7 +1,7 @@ -.. title:: clang-tidy - misc-dangling-handle +.. title:: clang-tidy - bugprone-dangling-handle -misc-dangling-handle -==================== +bugprone-dangling-handle +======================== Detect dangling references in value handles like ``std::experimental::string_view``. diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst index c389e54fc12..3f99f5b698f 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/list.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst @@ -19,6 +19,7 @@ Clang-Tidy Checks boost-use-to-string bugprone-argument-comment bugprone-copy-constructor-init + bugprone-dangling-handle bugprone-integer-division bugprone-misplaced-operator-in-strlen-in-alloc bugprone-string-constructor @@ -108,7 +109,6 @@ Clang-Tidy Checks llvm-twine-local misc-assert-side-effect misc-bool-pointer-implicit-conversion - misc-dangling-handle misc-definitions-in-headers misc-fold-init-type misc-forward-declaration-namespace diff --git a/clang-tools-extra/test/clang-tidy/misc-dangling-handle.cpp b/clang-tools-extra/test/clang-tidy/bugprone-dangling-handle.cpp index 08115a3cf75..80c84103126 100644 --- a/clang-tools-extra/test/clang-tidy/misc-dangling-handle.cpp +++ b/clang-tools-extra/test/clang-tidy/bugprone-dangling-handle.cpp @@ -1,6 +1,6 @@ -// RUN: %check_clang_tidy %s misc-dangling-handle %t -- \ +// RUN: %check_clang_tidy %s bugprone-dangling-handle %t -- \ // RUN: -config="{CheckOptions: \ -// RUN: [{key: misc-dangling-handle.HandleClasses, \ +// RUN: [{key: bugprone-dangling-handle.HandleClasses, \ // RUN: value: 'std::basic_string_view; ::llvm::StringRef;'}]}" \ // RUN: -- -std=c++11 @@ -79,7 +79,7 @@ std::string ReturnsAString(); void Positives() { std::string_view view1 = std::string(); - // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives its value [misc-dangling-handle] + // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives its value [bugprone-dangling-handle] std::string_view view_2 = ReturnsAString(); // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives |