diff options
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/google-readability-casting.cpp')
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/google-readability-casting.cpp | 65 |
1 files changed, 40 insertions, 25 deletions
diff --git a/clang-tools-extra/test/clang-tidy/google-readability-casting.cpp b/clang-tools-extra/test/clang-tidy/google-readability-casting.cpp index 9d9b578224c..f6c7cfb7dc5 100644 --- a/clang-tools-extra/test/clang-tidy/google-readability-casting.cpp +++ b/clang-tools-extra/test/clang-tidy/google-readability-casting.cpp @@ -15,14 +15,14 @@ void f(int a, double b, const char *cpc, const void *cpv, X *pX) { typedef const char *Typedef2; Typedef1 t1; (Typedef2)t1; - // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: possibly redundant cast between typedefs of the same type [google-readability-casting] - // CHECK-FIXES: {{^}} (Typedef2)t1; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant) [google-readability-casting] + // CHECK-FIXES: {{^}} static_cast<Typedef2>(t1); (const char*)t1; - // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: possibly redundant cast {{.*}} - // CHECK-FIXES: {{^}} (const char*)t1; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: {{.*}}; use static_cast (if needed + // CHECK-FIXES: {{^}} static_cast<const char*>(t1); (Typedef1)cpc; - // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: possibly redundant cast {{.*}} - // CHECK-FIXES: {{^}} (Typedef1)cpc; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: {{.*}}; use static_cast (if needed + // CHECK-FIXES: {{^}} static_cast<Typedef1>(cpc); (Typedef1)t1; // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant cast to the same type // CHECK-FIXES: {{^}} t1; @@ -30,64 +30,79 @@ void f(int a, double b, const char *cpc, const void *cpv, X *pX) { char *pc = (char*)cpc; // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: C-style casts are discouraged; use const_cast [google-readability-casting] // CHECK-FIXES: char *pc = const_cast<char*>(cpc); + typedef char Char; + Char *pChar = (Char*)pc; + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: {{.*}}; use static_cast (if needed + // CHECK-FIXES: {{^}} Char *pChar = static_cast<Char*>(pc); + + (Char)*cpc; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: {{.*}}; use static_cast (if needed + // CHECK-FIXES: {{^}} static_cast<Char>(*cpc); + + (char)*pChar; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: {{.*}}; use static_cast (if needed + // CHECK-FIXES: {{^}} static_cast<char>(*pChar); + + (const char*)cpv; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: {{.*}}; use static_cast [ + // CHECK-FIXES: static_cast<const char*>(cpv); char *pc2 = (char*)(cpc + 33); - // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char *pc2 = const_cast<char*>(cpc + 33); const char &crc = *cpc; char &rc = (char&)crc; - // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char &rc = const_cast<char&>(crc); char &rc2 = (char&)*cpc; - // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char &rc2 = const_cast<char&>(*cpc); char ** const* const* ppcpcpc; char ****ppppc = (char****)ppcpcpc; - // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char ****ppppc = const_cast<char****>(ppcpcpc); char ***pppc = (char***)*(ppcpcpc); - // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char ***pppc = const_cast<char***>(*(ppcpcpc)); char ***pppc2 = (char***)(*ppcpcpc); - // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: {{.*}}; use const_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: {{.*}}; use const_cast [ // CHECK-FIXES: char ***pppc2 = const_cast<char***>(*ppcpcpc); char *pc5 = (char*)(const char*)(cpv); - // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast {{.*}} - // CHECK-MESSAGES: :[[@LINE-2]]:22: warning: {{.*}}; use reinterpret_cast {{.*}} - // CHECK-FIXES: char *pc5 = const_cast<char*>(reinterpret_cast<const char*>(cpv)); + // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use const_cast [ + // CHECK-MESSAGES: :[[@LINE-2]]:22: warning: {{.*}}; use static_cast [ + // CHECK-FIXES: char *pc5 = const_cast<char*>(static_cast<const char*>(cpv)); int b1 = (int)b; - // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: {{.*}}; use static_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: {{.*}}; use static_cast [ // CHECK-FIXES: int b1 = static_cast<int>(b); Y *pB = (Y*)pX; - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [ Y &rB = (Y&)*pX; - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [ const char *pc3 = (const char*)cpv; - // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: {{.*}}; use reinterpret_cast {{.*}} - // CHECK-FIXES: const char *pc3 = reinterpret_cast<const char*>(cpv); + // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: {{.*}}; use static_cast [ + // CHECK-FIXES: const char *pc3 = static_cast<const char*>(cpv); char *pc4 = (char*)cpv; - // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [ // CHECK-FIXES: char *pc4 = (char*)cpv; b1 = (int)Enum1; - // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: {{.*}}; use static_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: {{.*}}; use static_cast [ // CHECK-FIXES: b1 = static_cast<int>(Enum1); Enum e = (Enum)b1; - // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: {{.*}}; use static_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: {{.*}}; use static_cast [ // CHECK-FIXES: Enum e = static_cast<Enum>(b1); - // CHECK-MESSAGES-NOT: warning: int b2 = int(b); int b3 = static_cast<double>(b); int b4 = b; @@ -99,7 +114,7 @@ void f(int a, double b, const char *cpc, const void *cpv, X *pX) { template <typename T> void template_function(T t, int n) { int i = (int)t; - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast {{.*}} + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: {{.*}}; use static_cast/const_cast/reinterpret_cast [ // CHECK-FIXES: int i = (int)t; int j = (int)n; // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant cast to the same type |
