summaryrefslogtreecommitdiffstats
path: root/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
index c727deb7969..31a1d96320e 100644
--- a/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
@@ -181,6 +181,12 @@ void PassByValueCheck::check(const MatchFinder::MatchResult &Result) {
if (!paramReferredExactlyOnce(Ctor, ParamDecl))
return;
+
+ // If the parameter is trivial to copy, don't move it. Moving a trivivally
+ // copyable type will cause a problem with modernize-pass-by-value
+ if (ParamDecl->getType().isTriviallyCopyableType(*Result.Context))
+ return;
+
auto Diag = diag(ParamDecl->getLocStart(), "pass by value and use std::move");
// Iterate over all declarations of the constructor.
OpenPOWER on IntegriCloud