summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--clang/tools/clang-shlib/CMakeLists.txt17
1 files changed, 16 insertions, 1 deletions
diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index a0fc8f6bfbd..07ee0f0a9a9 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -14,7 +14,22 @@ foreach (lib ${clang_libs})
list(APPEND _OBJECTS $<TARGET_OBJECTS:obj.${lib}>)
endif()
list(APPEND _DEPS $<TARGET_PROPERTY:${lib},INTERFACE_LINK_LIBRARIES>)
- list(APPEND _DEPS $<TARGET_PROPERTY:${lib},LINK_LIBRARIES>)
+
+ # clang libraries are redundant since we are linking all the individual
+ # object files into libclang-cpp.so, so filter them out from _DEPS.
+ # This avoids problems with LLVM global data when building with
+ # BUILD_SHARED_LIBS=ON
+ # FIXME: We could use list(FILTER) with cmake >= 3.6
+ # FIXME: With cmake >= 3.15 we could use the generator expression
+ # $<FILTER:list,INCLUDE|EXCLUDE,regex>
+ get_target_property(interface ${lib} LINK_LIBRARIES)
+ if (interface)
+ foreach(lib ${interface})
+ if (NOT ${lib} MATCHES "^clang")
+ list(APPEND _DEPS ${lib})
+ endif()
+ endforeach()
+ endif()
endforeach ()
if (CLANG_LINK_CLANG_DYLIB)
OpenPOWER on IntegriCloud