summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp2
-rw-r--r--llvm/test/MC/AArch64/ldr-pseudo-diagnostics.s18
2 files changed, 19 insertions, 1 deletions
diff --git a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
index 278c4b8f489..a1f32e099e3 100644
--- a/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
+++ b/llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
@@ -3178,7 +3178,7 @@ bool AArch64AsmParser::parseOperand(OperandVector &Operands, bool isCondCode,
if (Operands.size() < 2 ||
!static_cast<AArch64Operand &>(*Operands[1]).isReg())
- return true;
+ return Error(Loc, "Only valid when first operand is register");
bool IsXReg =
AArch64MCRegisterClasses[AArch64::GPR64allRegClassID].contains(
diff --git a/llvm/test/MC/AArch64/ldr-pseudo-diagnostics.s b/llvm/test/MC/AArch64/ldr-pseudo-diagnostics.s
index e32c5167952..e83ca93f6d2 100644
--- a/llvm/test/MC/AArch64/ldr-pseudo-diagnostics.s
+++ b/llvm/test/MC/AArch64/ldr-pseudo-diagnostics.s
@@ -12,3 +12,21 @@ f2:
// CHECK-ERROR: error: Immediate too large for register
// CHECK-ERROR: ldr w0, =-0x80000001
// CHECK-ERROR: ^
+
+f3:
+ ldr foo, =1
+// CHECK-ERROR: error: Only valid when first operand is register
+// CHECK-ERROR: ldr foo, =1
+// CHECK-ERROR: ^
+
+f4:
+ add r0, r0, =1
+// CHECK-ERROR: error: unexpected token in operand
+// CHECK-ERROR: add r0, r0, =1
+// CHECK-ERROR: ^
+
+f5:
+ ldr x0, =())
+// CHECK-ERROR: error: unknown token in expression
+// CHECK-ERROR: ldr x0, =())
+// CHECK-ERROR: ^
OpenPOWER on IntegriCloud