diff options
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 6 | ||||
| -rw-r--r-- | clang/test/SemaCXX/attr-target-mv.cpp | 7 |
2 files changed, 10 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 23fcfb4ec7c..1a7d9a84306 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -9175,9 +9175,9 @@ static bool CheckMultiVersionValue(Sema &S, const FunctionDecl *FD) { return true; } - for (const auto &Feature : ParseInfo.Features) { - auto BareFeat = StringRef{Feature}.substr(1); - if (Feature[0] == '-') { + for (const auto &Feat : ParseInfo.Features) { + auto BareFeat = StringRef{Feat}.substr(1); + if (Feat[0] == '-') { S.Diag(FD->getLocation(), diag::err_bad_multiversion_option) << Feature << ("no-" + BareFeat).str(); return true; diff --git a/clang/test/SemaCXX/attr-target-mv.cpp b/clang/test/SemaCXX/attr-target-mv.cpp index 18ec1bf7ca5..cc2d4f16c3f 100644 --- a/clang/test/SemaCXX/attr-target-mv.cpp +++ b/clang/test/SemaCXX/attr-target-mv.cpp @@ -1,4 +1,11 @@ // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -verify -fexceptions -fcxx-exceptions %s -std=c++14 +void __attribute__((target("default"))) invalid_features(void); +//expected-error@+2 {{function multiversioning doesn't support feature 'hello_world'}} +//expected-warning@+1 {{ignoring unsupported 'hello_world' in the target attribute string}} +void __attribute__((target("hello_world"))) invalid_features(void); +//expected-error@+1 {{function multiversioning doesn't support feature 'no-sse4.2'}} +void __attribute__((target("no-sse4.2"))) invalid_features(void); + void __attribute__((target("sse4.2"))) no_default(void); void __attribute__((target("arch=sandybridge"))) no_default(void); |
