diff options
-rw-r--r-- | lldb/packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py | 4 | ||||
-rw-r--r-- | lldb/tools/lldb-mi/MICmdBase.cpp | 3 | ||||
-rw-r--r-- | lldb/tools/lldb-mi/MICmdBase.h | 1 | ||||
-rw-r--r-- | lldb/tools/lldb-mi/MICmdCmdData.cpp | 2 | ||||
-rw-r--r-- | lldb/tools/lldb-mi/MICmdCmdData.h | 1 |
5 files changed, 8 insertions, 3 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py index 94e5042b3bf..3537096be7c 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py @@ -40,6 +40,10 @@ class MiDataTestCase(lldbmi_testcase.MiTestCaseBase): # Test -data-disassemble: try to disassemble some address self.runCmd("-data-disassemble -s %#x -e %#x -- 0" % (addr, addr + 0x10)) self.expect("\^done,asm_insns=\[{address=\"0x0*%x\",func-name=\"main\",offset=\"0\",size=\"[1-9]+\",inst=\".+?\"}," % addr) + + # Test -data-disassemble without "--" + self.runCmd("-data-disassemble -s %#x -e %#x 0" % (addr, addr + 0x10)) + self.expect("\^done,asm_insns=\[{address=\"0x0*%x\",func-name=\"main\",offset=\"0\",size=\"[1-9]+\",inst=\".+?\"}," % addr) # Run to hello_world self.runCmd("-break-insert -f hello_world") diff --git a/lldb/tools/lldb-mi/MICmdBase.cpp b/lldb/tools/lldb-mi/MICmdBase.cpp index 01fb9d102f7..2f63205dd9b 100644 --- a/lldb/tools/lldb-mi/MICmdBase.cpp +++ b/lldb/tools/lldb-mi/MICmdBase.cpp @@ -12,6 +12,7 @@ #include "MICmnMIValueConst.h" #include "MICmnLLDBDebugSessionInfo.h" #include "MICmdArgValOptionLong.h" +#include "MICmdArgValConsume.h" //++ ------------------------------------------------------------------------------------ // Details: CMICmdBase constructor. @@ -27,6 +28,7 @@ CMICmdBase::CMICmdBase() , m_constStrArgThreadGroup("thread-group") , m_constStrArgThread("thread") , m_constStrArgFrame("frame") + , m_constStrArgConsume("--") , m_ThreadGrpArgMandatory(false) , m_ThreadArgMandatory(false) , m_FrameArgMandatory(false) @@ -97,6 +99,7 @@ CMICmdBase::AddCommonArgs() m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgThreadGroup, m_ThreadGrpArgMandatory, true, CMICmdArgValListBase::eArgValType_ThreadGrp, 1)); m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgThread, m_ThreadArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1)); m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame, m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1)); + m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false)); } //++ ------------------------------------------------------------------------------------ diff --git a/lldb/tools/lldb-mi/MICmdBase.h b/lldb/tools/lldb-mi/MICmdBase.h index b072311f0bd..aa567482396 100644 --- a/lldb/tools/lldb-mi/MICmdBase.h +++ b/lldb/tools/lldb-mi/MICmdBase.h @@ -98,6 +98,7 @@ class CMICmdBase : public CMICmnBase, public CMICmdInvoker::ICmd, public CMICmdF const CMIUtilString m_constStrArgThreadGroup; const CMIUtilString m_constStrArgThread; const CMIUtilString m_constStrArgFrame; + const CMIUtilString m_constStrArgConsume; // These 3 members can be used by the derived classes to make any of // "thread", "frame" or "thread-group" mandatory. diff --git a/lldb/tools/lldb-mi/MICmdCmdData.cpp b/lldb/tools/lldb-mi/MICmdCmdData.cpp index 5d124cbf01a..0e0cf12b008 100644 --- a/lldb/tools/lldb-mi/MICmdCmdData.cpp +++ b/lldb/tools/lldb-mi/MICmdCmdData.cpp @@ -239,7 +239,6 @@ CMICmdCmdDataEvaluateExpression::HaveInvalidCharacterInExpression(const CMIUtilS CMICmdCmdDataDisassemble::CMICmdCmdDataDisassemble() : m_constStrArgAddrStart("s") , m_constStrArgAddrEnd("e") - , m_constStrArgConsume("--") , m_constStrArgMode("mode") , m_miValueList(true) { @@ -277,7 +276,6 @@ CMICmdCmdDataDisassemble::ParseArgs() new CMICmdArgValOptionShort(m_constStrArgAddrStart, true, true, CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1)); m_setCmdArgs.Add( new CMICmdArgValOptionShort(m_constStrArgAddrEnd, true, true, CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1)); - m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, true)); m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgMode, true, true)); return ParseValidateCmdOptions(); } diff --git a/lldb/tools/lldb-mi/MICmdCmdData.h b/lldb/tools/lldb-mi/MICmdCmdData.h index f738a4348e3..028c71387f3 100644 --- a/lldb/tools/lldb-mi/MICmdCmdData.h +++ b/lldb/tools/lldb-mi/MICmdCmdData.h @@ -106,7 +106,6 @@ class CMICmdCmdDataDisassemble : public CMICmdBase private: const CMIUtilString m_constStrArgAddrStart; // MI spec non mandatory, *this command mandatory const CMIUtilString m_constStrArgAddrEnd; // MI spec non mandatory, *this command mandatory - const CMIUtilString m_constStrArgConsume; const CMIUtilString m_constStrArgMode; CMICmnMIValueList m_miValueList; }; |