diff options
| -rw-r--r-- | llvm/lib/IR/Verifier.cpp | 9 | ||||
| -rw-r--r-- | llvm/test/Verifier/comdat3.ll | 5 |
2 files changed, 6 insertions, 8 deletions
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp index 43a023ec7c0..d01e1389436 100644 --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -793,16 +793,9 @@ void Verifier::visitMDImportedEntity(const MDImportedEntity &N) { } void Verifier::visitComdat(const Comdat &C) { - // All Comdat::SelectionKind values other than Comdat::Any require a - // GlobalValue with the same name as the Comdat. - const GlobalValue *GV = M->getNamedValue(C.getName()); - if (C.getSelectionKind() != Comdat::Any) - Assert1(GV, - "comdat selection kind requires a global value with the same name", - &C); // The Module is invalid if the GlobalValue has private linkage. Entities // with private linkage don't have entries in the symbol table. - if (GV) + if (const GlobalValue *GV = M->getNamedValue(C.getName())) Assert1(!GV->hasPrivateLinkage(), "comdat global value has private linkage", GV); } diff --git a/llvm/test/Verifier/comdat3.ll b/llvm/test/Verifier/comdat3.ll new file mode 100644 index 00000000000..28df930d9dd --- /dev/null +++ b/llvm/test/Verifier/comdat3.ll @@ -0,0 +1,5 @@ +; This used to be invalid, but now it's valid. Ensure the verifier +; doesn't reject it. +; RUN: llvm-as %s -o /dev/null + +$v = comdat largest |
