diff options
4 files changed, 7 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp index 46d522531a5..3d9f498b1e9 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp @@ -98,7 +98,7 @@ bool CommunicationKDP::SendRequestAndGetReply( #ifdef LLDB_CONFIGURATION_DEBUG // NOTE: this only works for packets that are in native endian byte order assert(request_packet.GetSize() == - *((uint16_t *)(request_packet.GetData() + 2))); + *((const uint16_t *)(request_packet.GetData() + 2))); #endif lldb::offset_t offset = 1; const uint32_t num_retries = 3; diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp index 1e20a090161..4d4a4f8c5c7 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp @@ -60,6 +60,7 @@ StateType GDBRemoteClientBase::SendContinuePacketAndWaitForResponse( continue; if (steady_clock::now() >= m_interrupt_time + kInterruptTimeout) return eStateInvalid; + break; } case PacketResult::Success: break; diff --git a/lldb/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp b/lldb/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp index 561fa91a0ee..99d6eb6c774 100644 --- a/lldb/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp +++ b/lldb/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp @@ -18,6 +18,7 @@ #include "lldb/API/SBTarget.h" #include "lldb/API/SBThread.h" #include "lldb/API/SBUnixSignals.h" +#include "llvm/Support/Compiler.h" #ifdef _WIN32 #include <io.h> // For the ::_access() #else @@ -899,6 +900,7 @@ bool CMICmnLLDBDebuggerHandleEvents::HandleProcessEventBroadcastBitStateChanged( bOk = HandleProcessEventStateStopped(vEvent, bShouldBrk); if (bShouldBrk) break; + break; case lldb::eStateCrashed: case lldb::eStateSuspended: pEventType = "eStateSuspended"; diff --git a/lldb/tools/lldb-mi/MIUtilString.cpp b/lldb/tools/lldb-mi/MIUtilString.cpp index 45196a70398..3797d100179 100644 --- a/lldb/tools/lldb-mi/MIUtilString.cpp +++ b/lldb/tools/lldb-mi/MIUtilString.cpp @@ -8,6 +8,7 @@ //===----------------------------------------------------------------------===// // Third party headers +#include "llvm/Support/Compiler.h" #include <cstdlib> #include <inttypes.h> // for PRIx8 #include <limits.h> // for ULONG_MAX @@ -890,7 +891,7 @@ CMIUtilString CMIUtilString::ConvertToPrintableASCII(const char vChar, case '"': if (bEscapeQuotes) return "\\\""; - // fall thru + LLVM_FALLTHROUGH; default: if (::isprint(vChar)) return Format("%c", vChar); @@ -924,7 +925,7 @@ CMIUtilString::ConvertCharValueToPrintableASCII(char vChar, case '"': if (bEscapeQuotes) return "\\\""; - // fall thru + LLVM_FALLTHROUGH; default: if (::isprint(vChar)) return Format("%c", vChar); |
