summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.cpp14
-rw-r--r--clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.h2
2 files changed, 7 insertions, 9 deletions
diff --git a/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.cpp b/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.cpp
index 6b418d49a28..fb8c5835db1 100644
--- a/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.cpp
+++ b/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.cpp
@@ -19,10 +19,10 @@ namespace clang {
namespace tidy {
namespace cert {
-const char SetLongJmpCheck::DiagWording[] =
+namespace {
+const char DiagWording[] =
"do not call %0; consider using exception handling instead";
-namespace {
class SetJmpMacroCallbacks : public PPCallbacks {
SetLongJmpCheck &Check;
@@ -36,7 +36,7 @@ public:
return;
if (II->getName() == "setjmp")
- Check.diag(Range.getBegin(), Check.DiagWording) << II;
+ Check.diag(Range.getBegin(), DiagWording) << II;
}
};
} // namespace
@@ -62,10 +62,10 @@ void SetLongJmpCheck::registerMatchers(MatchFinder *Finder) {
// In case there is an implementation that happens to define setjmp as a
// function instead of a macro, this will also catch use of it. However, we
// are primarily searching for uses of longjmp.
- Finder->addMatcher(callExpr(callee(functionDecl(anyOf(hasName("setjmp"),
- hasName("longjmp")))))
- .bind("expr"),
- this);
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(hasAnyName("setjmp", "longjmp"))))
+ .bind("expr"),
+ this);
}
void SetLongJmpCheck::check(const MatchFinder::MatchResult &Result) {
diff --git a/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.h b/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.h
index ea20ba7fa80..660545dc158 100644
--- a/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.h
+++ b/clang-tools-extra/clang-tidy/cert/SetLongJmpCheck.h
@@ -26,8 +26,6 @@ public:
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
void registerPPCallbacks(CompilerInstance &Compiler) override;
-
- static const char DiagWording[];
};
} // namespace cert
OpenPOWER on IntegriCloud