diff options
| -rw-r--r-- | clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp | 3 | ||||
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp | 7 |
2 files changed, 9 insertions, 1 deletions
diff --git a/clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp index cbc1f34cfca..d234fa74abc 100644 --- a/clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp @@ -19,7 +19,8 @@ namespace bugprone { namespace { AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) { - return !Node.isTriviallyCopyable(); + // For incomplete types, assume they are TriviallyCopyable. + return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false; } } // namespace diff --git a/clang-tools-extra/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp b/clang-tools-extra/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp index 2f68bc26250..e0760d393f4 100644 --- a/clang-tools-extra/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp +++ b/clang-tools-extra/test/clang-tidy/bugprone-undefined-memory-manipulation.cpp @@ -52,6 +52,13 @@ struct VirtualBase : virtual Base { int vb; }; +// Incomplete type, assume it is TriviallyCopyable. +struct NoDef; + +void f(NoDef *s) { + memset(s, 0, 5); +} + template <typename T> void memset_temp(T *b) { memset(b, 0, sizeof(T)); |
