diff options
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 5 | ||||
| -rw-r--r-- | clang/test/CodeGen/microsoft-no-common-align.c | 8 |
2 files changed, 13 insertions, 0 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 54190493f04..ab0ac67d8e8 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -3761,6 +3761,11 @@ static bool isVarDeclStrongDefinition(const ASTContext &Context, } } } + // COFF doesn't support alignments greater than 32, so these cannot be + // in common. + if (Context.getTargetInfo().getTriple().isKnownWindowsMSVCEnvironment() && + Context.getTypeAlignIfKnown(D->getType()) > 32) + return true; return false; } diff --git a/clang/test/CodeGen/microsoft-no-common-align.c b/clang/test/CodeGen/microsoft-no-common-align.c new file mode 100644 index 00000000000..fc46946c00e --- /dev/null +++ b/clang/test/CodeGen/microsoft-no-common-align.c @@ -0,0 +1,8 @@ +// RUN: %clang_cc1 -triple x86_64-windows-msvc -emit-llvm -o - %s | FileCheck %s +typedef float TooLargeAlignment __attribute__((__vector_size__(64))); +typedef float NormalAlignment __attribute__((__vector_size__(4))); + +TooLargeAlignment TooBig; +// CHECK: @TooBig = dso_local global <16 x float> zeroinitializer, align 64 +NormalAlignment JustRight; +// CHECK: @JustRight = common dso_local global <1 x float> zeroinitializer, align 4 |
