summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--clang-tools-extra/clang-rename/USRLocFinder.cpp34
-rw-r--r--clang-tools-extra/test/clang-rename/DynamicCastExpr.cpp25
2 files changed, 46 insertions, 13 deletions
diff --git a/clang-tools-extra/clang-rename/USRLocFinder.cpp b/clang-tools-extra/clang-rename/USRLocFinder.cpp
index be110f15276..2a8804d3e63 100644
--- a/clang-tools-extra/clang-rename/USRLocFinder.cpp
+++ b/clang-tools-extra/clang-rename/USRLocFinder.cpp
@@ -124,20 +124,11 @@ public:
}
bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) {
- clang::QualType Type = Expr->getType();
- // See if this a cast of a pointer.
- const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
- if (!Decl) {
- // See if this is a cast of a reference.
- Decl = Type->getAsCXXRecordDecl();
- }
-
- if (Decl && getUSRForDecl(Decl) == USR) {
- SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
- LocationsFound.push_back(Location);
- }
+ return handleCXXNamedCastExpr(Expr);
+ }
- return true;
+ bool VisitCXXDynamicCastExpr(clang::CXXDynamicCastExpr *Expr) {
+ return handleCXXNamedCastExpr(Expr);
}
// Non-visitors:
@@ -159,6 +150,23 @@ private:
}
}
+ bool handleCXXNamedCastExpr(clang::CXXNamedCastExpr *Expr) {
+ clang::QualType Type = Expr->getType();
+ // See if this a cast of a pointer.
+ const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
+ if (!Decl) {
+ // See if this is a cast of a reference.
+ Decl = Type->getAsCXXRecordDecl();
+ }
+
+ if (Decl && getUSRForDecl(Decl) == USR) {
+ SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
+ LocationsFound.push_back(Location);
+ }
+
+ return true;
+ }
+
// All the locations of the USR were found.
const std::string USR;
// Old name that is renamed.
diff --git a/clang-tools-extra/test/clang-rename/DynamicCastExpr.cpp b/clang-tools-extra/test/clang-rename/DynamicCastExpr.cpp
new file mode 100644
index 00000000000..91d4f25ab07
--- /dev/null
+++ b/clang-tools-extra/test/clang-rename/DynamicCastExpr.cpp
@@ -0,0 +1,25 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=186 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Base {
+ virtual int getValue() const = 0;
+};
+
+class Derived : public Base {
+public:
+ int getValue() const {
+ return 0;
+ }
+};
+
+int main() {
+ Derived D;
+ const Base &Reference = D;
+ const Base *Pointer = &D;
+
+ dynamic_cast<const Derived &>(Reference).getValue(); // CHECK: dynamic_cast<const X &>
+ dynamic_cast<const Derived *>(Pointer)->getValue(); // CHECK: dynamic_cast<const X *>
+}
+
+// Use grep -FUbo 'Derived' <file> to get the correct offset of foo when changing
+// this file.
OpenPOWER on IntegriCloud