diff options
| -rw-r--r-- | lld/ELF/Writer.cpp | 3 | ||||
| -rw-r--r-- | lld/test/ELF/invalid/Inputs/symtab-sh_info3.elf | bin | 0 -> 470 bytes | |||
| -rw-r--r-- | lld/test/ELF/invalid/symtab-sh-info.s | 5 |
3 files changed, 8 insertions, 0 deletions
diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp index 1cb47b81adf..a7ba822fd23 100644 --- a/lld/ELF/Writer.cpp +++ b/lld/ELF/Writer.cpp @@ -366,6 +366,9 @@ template <class ELFT> void Writer<ELFT>::copyLocalSymbols() { for (elf::ObjectFile<ELFT> *F : Symtab<ELFT>::X->getObjectFiles()) { StringRef StrTab = F->getStringTable(); for (SymbolBody *B : F->getLocalSymbols()) { + if (!B->IsLocal) + fatal(getFilename(F) + + ": broken object: getLocalSymbols returns a non-local symbol"); auto *DR = dyn_cast<DefinedRegular<ELFT>>(B); // No reason to keep local undefined symbol in symtab. if (!DR) diff --git a/lld/test/ELF/invalid/Inputs/symtab-sh_info3.elf b/lld/test/ELF/invalid/Inputs/symtab-sh_info3.elf Binary files differnew file mode 100644 index 00000000000..ca889fbca1a --- /dev/null +++ b/lld/test/ELF/invalid/Inputs/symtab-sh_info3.elf diff --git a/lld/test/ELF/invalid/symtab-sh-info.s b/lld/test/ELF/invalid/symtab-sh-info.s index 727639f4910..3522ae550c0 100644 --- a/lld/test/ELF/invalid/symtab-sh-info.s +++ b/lld/test/ELF/invalid/symtab-sh-info.s @@ -2,3 +2,8 @@ ## so sh_info should be at least 1 in a valid ELF. # RUN: not ld.lld %p/Inputs/symtab-sh_info2.elf -o %t2 2>&1 | FileCheck %s # CHECK: invalid sh_info in symbol table + +## sh_info contains invalid value saying non-local symbol is local. +# RUN: not ld.lld %p/Inputs/symtab-sh_info3.elf -o %t2 2>&1 | \ +# RUN: FileCheck --check-prefix=INVALID-SYMTAB-SHINFO %s +# INVALID-SYMTAB-SHINFO: broken object: getLocalSymbols returns a non-local symbol |
