diff options
| -rw-r--r-- | lld/ELF/Symbols.cpp | 6 | ||||
| -rw-r--r-- | lld/test/ELF/invalid/Inputs/tls-symbol.elf | bin | 0 -> 456 bytes | |||
| -rw-r--r-- | lld/test/ELF/invalid/tls-symbol.s | 5 |
3 files changed, 10 insertions, 1 deletions
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp index 4819bb17ae8..74572244f2d 100644 --- a/lld/ELF/Symbols.cpp +++ b/lld/ELF/Symbols.cpp @@ -59,8 +59,12 @@ static typename ELFT::uint getSymVA(const SymbolBody &Body, Addend = 0; } uintX_t VA = (SC->OutSec ? SC->OutSec->getVA() : 0) + SC->getOffset(Offset); - if (D.isTls() && !Config->Relocatable) + if (D.isTls() && !Config->Relocatable) { + if (!Out<ELFT>::TlsPhdr) + fatal(getFilename(D.File) + + " has a STT_TLS symbol but doesn't have a PT_TLS section"); return VA - Out<ELFT>::TlsPhdr->p_vaddr; + } return VA; } case SymbolBody::DefinedCommonKind: diff --git a/lld/test/ELF/invalid/Inputs/tls-symbol.elf b/lld/test/ELF/invalid/Inputs/tls-symbol.elf Binary files differnew file mode 100644 index 00000000000..78c759897dd --- /dev/null +++ b/lld/test/ELF/invalid/Inputs/tls-symbol.elf diff --git a/lld/test/ELF/invalid/tls-symbol.s b/lld/test/ELF/invalid/tls-symbol.s new file mode 100644 index 00000000000..7c65c6c9f2c --- /dev/null +++ b/lld/test/ELF/invalid/tls-symbol.s @@ -0,0 +1,5 @@ +# REQUIRES: x86 + +## The test file contains a STT_TLS symbol but has no TLS section. +# RUN: not ld.lld %S/Inputs/tls-symbol.elf -o %t 2>&1 | FileCheck %s +# CHECK: has a STT_TLS symbol but doesn't have a PT_TLS section |
