diff options
| -rw-r--r-- | llvm/lib/Transforms/Scalar/LowerInvoke.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/Scalar/LowerInvoke.cpp b/llvm/lib/Transforms/Scalar/LowerInvoke.cpp index 0f664e151f9..d74633b82b8 100644 --- a/llvm/lib/Transforms/Scalar/LowerInvoke.cpp +++ b/llvm/lib/Transforms/Scalar/LowerInvoke.cpp @@ -412,6 +412,14 @@ bool LowerInvoke::insertExpensiveEHSupport(Function &F) { NumInvokes += Invokes.size(); NumUnwinds += Unwinds.size(); + + // TODO: This is not an optimal way to do this. In particular, this always + // inserts setjmp calls into the entries of functions with invoke instructions + // even though there are possibly paths through the function that do not + // execute any invokes. In particular, for functions with early exits, e.g. + // the 'addMove' method in hexxagon, it would be nice to not have to do the + // setjmp stuff on the early exit path. This requires a bit of dataflow, but + // would not be too hard to do. // If we have an invoke instruction, insert a setjmp that dominates all // invokes. After the setjmp, use a cond branch that goes to the original |
