diff options
3 files changed, 12 insertions, 12 deletions
diff --git a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp index 566fefaf798..9cac499c0ff 100644 --- a/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp +++ b/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp @@ -171,6 +171,7 @@ UtilityFunction *AppleObjCRuntimeV1::CreateObjectChecker(const char *name) { " \n", name); assert(strformatsize < (int)sizeof(buf->contents)); + (void)strformatsize; Status error; return GetTargetRef().GetUtilityFunctionForLanguage( diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index cb00e840673..f5418763d67 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -3732,8 +3732,8 @@ static DWARFDIE GetContainingFunctionWithAbstractOrigin(const DWARFDIE &die) { } } } - assert(!"Shouldn't call GetContainingFunctionWithAbstractOrigin on something " - "not in a function"); + assert(0 && "Shouldn't call GetContainingFunctionWithAbstractOrigin on " + "something not in a function"); return DWARFDIE(); } diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp index 6fbeab13b82..8f6f9f0684a 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp @@ -404,7 +404,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendStartTracePacket) { R"( {"psb" : 1,"tracetech" : "intel-pt"},"threadid" : 35,"type" : 1})"; HandlePacket(server, (expected_packet1 + expected_packet2), "1"); ASSERT_TRUE(error.Success()); - ASSERT_EQ(result.get(), 1); + ASSERT_EQ(result.get(), 1u); error.Clear(); result = std::async(std::launch::async, [&] { @@ -466,7 +466,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetDataPacket) { std::string expected_packet2 = R"("traceid" : 3})"; HandlePacket(server, expected_packet1+expected_packet2, "123456"); ASSERT_TRUE(result.get().Success()); - ASSERT_EQ(buffer.size(), 3); + ASSERT_EQ(buffer.size(), 3u); ASSERT_EQ(buf[0], 0x12); ASSERT_EQ(buf[1], 0x34); ASSERT_EQ(buf[2], 0x56); @@ -478,7 +478,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetDataPacket) { HandlePacket(server, expected_packet1+expected_packet2, "E23"); ASSERT_FALSE(result.get().Success()); - ASSERT_EQ(buffer2.size(), 0); + ASSERT_EQ(buffer2.size(), 0u); } TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) { @@ -504,7 +504,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) { std::string expected_packet2 = R"("traceid" : 3})"; HandlePacket(server, expected_packet1+expected_packet2, "123456"); ASSERT_TRUE(result.get().Success()); - ASSERT_EQ(buffer.size(), 3); + ASSERT_EQ(buffer.size(), 3u); ASSERT_EQ(buf[0], 0x12); ASSERT_EQ(buf[1], 0x34); ASSERT_EQ(buf[2], 0x56); @@ -516,7 +516,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) { HandlePacket(server, expected_packet1+expected_packet2, "E23"); ASSERT_FALSE(result.get().Success()); - ASSERT_EQ(buffer2.size(), 0); + ASSERT_EQ(buffer2.size(), 0u); } TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) { @@ -543,8 +543,8 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) { R"(],"metabuffersize" : 8192,"threadid" : 35,"type" : 1}])"; HandlePacket(server, expected_packet, response1+response2); ASSERT_TRUE(result.get().Success()); - ASSERT_EQ(options.getTraceBufferSize(), 8192); - ASSERT_EQ(options.getMetaDataBufferSize(), 8192); + ASSERT_EQ(options.getTraceBufferSize(), 8192u); + ASSERT_EQ(options.getMetaDataBufferSize(), 8192u); ASSERT_EQ(options.getType(), 1); auto custom_params = options.getTraceParams(); @@ -554,9 +554,8 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) { ASSERT_TRUE(custom_params); ASSERT_EQ(custom_params->GetType(), eStructuredDataTypeDictionary); - ASSERT_TRUE( - custom_params->GetValueForKeyAsInteger<uint64_t>("psb", psb_value)); - ASSERT_EQ(psb_value, 1); + ASSERT_TRUE(custom_params->GetValueForKeyAsInteger("psb", psb_value)); + ASSERT_EQ(psb_value, 1u); ASSERT_TRUE( custom_params->GetValueForKeyAsString("tracetech", trace_tech_value)); ASSERT_STREQ(trace_tech_value.data(), "intel-pt"); |
