diff options
| -rw-r--r-- | lld/ELF/InputFiles.cpp | 6 | ||||
| -rw-r--r-- | lld/test/ELF/lto/undef-weak.ll | 29 |
2 files changed, 32 insertions, 3 deletions
diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 5f5ac9e0e2f..78abcf95fbe 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -454,11 +454,11 @@ void BitcodeFile::parse() { StringRef NameRef = Saver.save(StringRef(Name)); SymbolBody *Body; uint32_t Flags = Sym.getFlags(); + bool IsWeak = Flags & BasicSymbolRef::SF_Weak; if (Flags & BasicSymbolRef::SF_Undefined) - Body = new (Alloc) Undefined(NameRef, false, STV_DEFAULT, false); + Body = new (Alloc) Undefined(NameRef, IsWeak, STV_DEFAULT, false); else - Body = - new (Alloc) DefinedBitcode(NameRef, Flags & BasicSymbolRef::SF_Weak); + Body = new (Alloc) DefinedBitcode(NameRef, IsWeak); SymbolBodies.push_back(Body); } } diff --git a/lld/test/ELF/lto/undef-weak.ll b/lld/test/ELF/lto/undef-weak.ll new file mode 100644 index 00000000000..215978a73df --- /dev/null +++ b/lld/test/ELF/lto/undef-weak.ll @@ -0,0 +1,29 @@ +; REQUIRES: x86 + +; RUN: llvm-as %S/Inputs/archive.ll -o %t1.o +; RUN: rm -f %t.a +; RUN: llvm-ar rcs %t.a %t1.o + + +; RUN: llvm-as %s -o %t2.o +; RUN: ld.lld -m elf_x86_64 %t2.o -o %t2.so %t.a -shared +; RUN: llvm-readobj -t %t2.so | FileCheck %s +target triple = "x86_64-unknown-linux-gnu" +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" + +declare extern_weak void @f() +define void @foo() { + call void @f() + ret void +} + +; We should not fetch the archive member. + +; CHECK: Name: f ({{.*}}) +; CHECK-NEXT: Value: 0x0 +; CHECK-NEXT: Size: 0 +; CHECK-NEXT: Binding: Weak +; CHECK-NEXT: Type: None +; CHECK-NEXT: Other: 0 +; CHECK-NEXT: Section: Undefined + |
