diff options
8 files changed, 117 insertions, 0 deletions
diff --git a/clang-tools-extra/clang-tidy/google/CMakeLists.txt b/clang-tools-extra/clang-tidy/google/CMakeLists.txt index 42274dcb717..efe3b3cde9c 100644 --- a/clang-tools-extra/clang-tidy/google/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/google/CMakeLists.txt @@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS support) add_clang_library(clangTidyGoogleModule AvoidCStyleCastsCheck.cpp + DefaultArgumentsCheck.cpp ExplicitConstructorCheck.cpp ExplicitMakePairCheck.cpp GlobalNamesInHeadersCheck.cpp diff --git a/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.cpp b/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.cpp new file mode 100644 index 00000000000..ccbd870a6ec --- /dev/null +++ b/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.cpp @@ -0,0 +1,36 @@ +//===--- DefaultArgumentsCheck.cpp - clang-tidy----------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "DefaultArgumentsCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang { +namespace tidy { +namespace google { + +void DefaultArgumentsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + cxxMethodDecl(anyOf(isOverride(), isVirtual()), + hasAnyParameter(parmVarDecl(hasInitializer(expr())))) + .bind("Decl"), + this); +} + +void DefaultArgumentsCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedDecl = Result.Nodes.getNodeAs<CXXMethodDecl>("Decl"); + diag(MatchedDecl->getLocation(), + "default arguments on virtual or override methods are prohibited"); +} + +} // namespace google +} // namespace tidy +} // namespace clang diff --git a/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.h b/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.h new file mode 100644 index 00000000000..1457a093db6 --- /dev/null +++ b/clang-tools-extra/clang-tidy/google/DefaultArgumentsCheck.h @@ -0,0 +1,34 @@ +//===--- DefaultArgumentsCheck.h - clang-tidy--------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_DEFAULT_ARGUMENTS_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_DEFAULT_ARGUMENTS_H + +#include "../ClangTidy.h" + +namespace clang { +namespace tidy { +namespace google { + +/// Checks that default parameters are not given for virtual methods. +/// +/// See https://google.github.io/styleguide/cppguide.html#Default_Arguments +class DefaultArgumentsCheck : public ClangTidyCheck { +public: + DefaultArgumentsCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context) {} + void registerMatchers(ast_matchers::MatchFinder *Finder) override; + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + +} // namespace google +} // namespace tidy +} // namespace clang + +#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_DEFAULT_ARGUMENTS_H diff --git a/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp b/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp index 1281e15ff7b..49f879ccd9d 100644 --- a/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp +++ b/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp @@ -15,6 +15,7 @@ #include "../readability/NamespaceCommentCheck.h" #include "../readability/RedundantSmartptrGetCheck.h" #include "AvoidCStyleCastsCheck.h" +#include "DefaultArgumentsCheck.h" #include "ExplicitConstructorCheck.h" #include "ExplicitMakePairCheck.h" #include "GlobalNamesInHeadersCheck.h" @@ -42,6 +43,8 @@ public: "google-build-namespaces"); CheckFactories.registerCheck<build::UsingNamespaceDirectiveCheck>( "google-build-using-namespace"); + CheckFactories.registerCheck<DefaultArgumentsCheck>( + "google-default-arguments"); CheckFactories.registerCheck<ExplicitConstructorCheck>( "google-explicit-constructor"); CheckFactories.registerCheck<runtime::IntegerTypesCheck>( diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index a1d3b74c80a..2220e012365 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -100,6 +100,11 @@ identified. The improvements since the 3.8 release include: Flags user-defined constructor definitions that do not initialize all builtin and pointer fields which leaves their memory in an undefined state. +- New `google-default-arguments + <http://clang.llvm.org/extra/clang-tidy/checks/google-default-arguments.html>`_ check + + Flags default arguments in virtual methods. + - New `misc-dangling-handle <http://clang.llvm.org/extra/clang-tidy/checks/misc-dangling-handle.html>`_ check diff --git a/clang-tools-extra/docs/clang-tidy/checks/google-default-arguments.rst b/clang-tools-extra/docs/clang-tidy/checks/google-default-arguments.rst new file mode 100644 index 00000000000..c02099c6ed1 --- /dev/null +++ b/clang-tools-extra/docs/clang-tidy/checks/google-default-arguments.rst @@ -0,0 +1,8 @@ +.. title:: clang-tidy - google-default-arguments + +google-default-arguments +======================== + +Checks that default arguments are not given for virtual methods. + +See https://google.github.io/styleguide/cppguide.html#Default_Arguments diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst index 87e62bffccc..8c9ab42eb22 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/list.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst @@ -33,6 +33,7 @@ Clang-Tidy Checks google-build-explicit-make-pair google-build-namespaces google-build-using-namespace + google-default-arguments google-explicit-constructor google-global-names-in-headers google-readability-braces-around-statements (redirects to readability-braces-around-statements) <google-readability-braces-around-statements> diff --git a/clang-tools-extra/test/clang-tidy/google-default-arguments.cpp b/clang-tools-extra/test/clang-tidy/google-default-arguments.cpp new file mode 100644 index 00000000000..48d3f2d2bd7 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/google-default-arguments.cpp @@ -0,0 +1,29 @@ +// RUN: %check_clang_tidy %s google-default-arguments %t + +struct A { + virtual void f(int I, int J = 3); + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: default arguments on virtual or override methods are prohibited [google-default-arguments] +}; + +struct B : public A { + void f(int I, int J = 5); + // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default arguments on virtual or override methods are prohibited +}; + +struct C : public B { + void f(int I, int J = 5) override; + // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default arguments on virtual or override methods are prohibited +}; + +// Negatives. +struct D : public B { + void f(int I, int J) override; +}; + +struct X { + void f(int I, int J = 3); +}; + +struct Y : public X { + void f(int I, int J = 5); +}; |
