diff options
| -rw-r--r-- | clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp | 4 | ||||
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/misc-definitions-in-headers.hpp | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp index 25fc09288b0..77ca26fdb34 100644 --- a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp @@ -126,8 +126,8 @@ void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) { diag(FD->getLocation(), "function %0 defined in a header file; " "function definitions in header files can lead to ODR violations") - << FD << FixItHint::CreateInsertion(FD->getSourceRange().getBegin(), - "inline "); + << FD << FixItHint::CreateInsertion( + FD->getReturnTypeSourceRange().getBegin(), "inline "); } else if (const auto *VD = dyn_cast<VarDecl>(ND)) { // Static data members of a class template are allowed. if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember()) diff --git a/clang-tools-extra/test/clang-tidy/misc-definitions-in-headers.hpp b/clang-tools-extra/test/clang-tidy/misc-definitions-in-headers.hpp index 9a383e16316..1c9c96ea094 100644 --- a/clang-tools-extra/test/clang-tidy/misc-definitions-in-headers.hpp +++ b/clang-tools-extra/test/clang-tidy/misc-definitions-in-headers.hpp @@ -29,6 +29,7 @@ void CA::f2() { } template <> int CA::f3() { // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: function 'f3<int>' defined in a header file; +// CHECK-FIXES: inline int CA::f3() { int a = 1; return a; } @@ -90,8 +91,9 @@ T f3() { } template <> -// CHECK-MESSAGES: :[[@LINE+1]]:5: warning: function 'f3<int>' defined in a header file; int f3() { +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'f3<int>' defined in a header file; +// CHECK-FIXES: inline int f3() { int a = 1; return a; } @@ -153,6 +155,7 @@ struct CD<int, int> { int CD<int, int>::f() { // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: function 'f' defined in a header file; +// CHECK-FIXES: inline int CD<int, int>::f() { return 0; } |
