diff options
| author | Vedant Kumar <vsk@apple.com> | 2016-07-15 01:19:33 +0000 |
|---|---|---|
| committer | Vedant Kumar <vsk@apple.com> | 2016-07-15 01:19:33 +0000 |
| commit | f681e2e50647ed74992ea8476606e49d87b412c6 (patch) | |
| tree | 988b71e5ddb52803c2d52fd974f9e65f22ca0e66 /llvm | |
| parent | bb579542419ca790de86c31339e2c652ed7f8d11 (diff) | |
| download | bcm5719-llvm-f681e2e50647ed74992ea8476606e49d87b412c6.tar.gz bcm5719-llvm-f681e2e50647ed74992ea8476606e49d87b412c6.zip | |
[Coverage] Mark a few more methods const (NFC)
llvm-svn: 275514
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h | 7 | ||||
| -rw-r--r-- | llvm/lib/ProfileData/Coverage/CoverageMapping.cpp | 8 | ||||
| -rw-r--r-- | llvm/tools/llvm-cov/CodeCoverage.cpp | 22 |
3 files changed, 19 insertions, 18 deletions
diff --git a/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h b/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h index cb0e17b94f9..6afde56122f 100644 --- a/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h +++ b/llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h @@ -480,13 +480,14 @@ public: /// /// Functions that are instantiated more than once, such as C++ template /// specializations, have distinct coverage records for each instantiation. - std::vector<const FunctionRecord *> getInstantiations(StringRef Filename); + std::vector<const FunctionRecord *> + getInstantiations(StringRef Filename) const; /// \brief Get the coverage for a particular function. - CoverageData getCoverageForFunction(const FunctionRecord &Function); + CoverageData getCoverageForFunction(const FunctionRecord &Function) const; /// \brief Get the coverage for an expansion within a coverage set. - CoverageData getCoverageForExpansion(const ExpansionRecord &Expansion); + CoverageData getCoverageForExpansion(const ExpansionRecord &Expansion) const; }; // Profile coverage map has the following layout: diff --git a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp index 73037347e3a..fcd4e24bdfc 100644 --- a/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp +++ b/llvm/lib/ProfileData/Coverage/CoverageMapping.cpp @@ -478,7 +478,7 @@ CoverageData CoverageMapping::getCoverageForFile(StringRef Filename) const { } std::vector<const FunctionRecord *> -CoverageMapping::getInstantiations(StringRef Filename) { +CoverageMapping::getInstantiations(StringRef Filename) const { FunctionInstantiationSetCollector InstantiationSetCollector; for (const auto &Function : Functions) { auto MainFileID = findMainViewFileID(Filename, Function); @@ -498,7 +498,7 @@ CoverageMapping::getInstantiations(StringRef Filename) { } CoverageData -CoverageMapping::getCoverageForFunction(const FunctionRecord &Function) { +CoverageMapping::getCoverageForFunction(const FunctionRecord &Function) const { auto MainFileID = findMainViewFileID(Function); if (!MainFileID) return CoverageData(); @@ -518,8 +518,8 @@ CoverageMapping::getCoverageForFunction(const FunctionRecord &Function) { return FunctionCoverage; } -CoverageData -CoverageMapping::getCoverageForExpansion(const ExpansionRecord &Expansion) { +CoverageData CoverageMapping::getCoverageForExpansion( + const ExpansionRecord &Expansion) const { CoverageData ExpansionCoverage( Expansion.Function.Filenames[Expansion.FileID]); std::vector<coverage::CountedRegion> Regions; diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index 693c8024920..eda074cc44e 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -67,17 +67,18 @@ public: /// \brief Create source views for the expansions of the view. void attachExpansionSubViews(SourceCoverageView &View, ArrayRef<ExpansionRecord> Expansions, - CoverageMapping &Coverage); + const CoverageMapping &Coverage); /// \brief Create the source view of a particular function. std::unique_ptr<SourceCoverageView> - createFunctionView(const FunctionRecord &Function, CoverageMapping &Coverage); + createFunctionView(const FunctionRecord &Function, + const CoverageMapping &Coverage); /// \brief Create the main source view of a particular source file. std::unique_ptr<SourceCoverageView> - createSourceFileView(StringRef SourceFile, CoverageMapping &Coverage); + createSourceFileView(StringRef SourceFile, const CoverageMapping &Coverage); - /// \brief Load the coverage mapping data. Return true if an error occured. + /// \brief Load the coverage mapping data. Return nullptr if an error occured. std::unique_ptr<CoverageMapping> load(); int run(Command Cmd, int argc, const char **argv); @@ -168,10 +169,9 @@ CodeCoverageTool::getSourceFile(StringRef SourceFile) { return *LoadedSourceFiles.back().second; } -void -CodeCoverageTool::attachExpansionSubViews(SourceCoverageView &View, - ArrayRef<ExpansionRecord> Expansions, - CoverageMapping &Coverage) { +void CodeCoverageTool::attachExpansionSubViews( + SourceCoverageView &View, ArrayRef<ExpansionRecord> Expansions, + const CoverageMapping &Coverage) { if (!ViewOpts.ShowExpandedRegions) return; for (const auto &Expansion : Expansions) { @@ -193,7 +193,7 @@ CodeCoverageTool::attachExpansionSubViews(SourceCoverageView &View, std::unique_ptr<SourceCoverageView> CodeCoverageTool::createFunctionView(const FunctionRecord &Function, - CoverageMapping &Coverage) { + const CoverageMapping &Coverage) { auto FunctionCoverage = Coverage.getCoverageForFunction(Function); if (FunctionCoverage.empty()) return nullptr; @@ -211,7 +211,7 @@ CodeCoverageTool::createFunctionView(const FunctionRecord &Function, std::unique_ptr<SourceCoverageView> CodeCoverageTool::createSourceFileView(StringRef SourceFile, - CoverageMapping &Coverage) { + const CoverageMapping &Coverage) { auto SourceBuffer = getSourceFile(SourceFile); if (!SourceBuffer) return nullptr; @@ -224,7 +224,7 @@ CodeCoverageTool::createSourceFileView(StringRef SourceFile, ViewOpts, std::move(FileCoverage)); attachExpansionSubViews(*View, Expansions, Coverage); - for (auto Function : Coverage.getInstantiations(SourceFile)) { + for (const auto *Function : Coverage.getInstantiations(SourceFile)) { auto SubViewCoverage = Coverage.getCoverageForFunction(*Function); auto SubViewExpansions = SubViewCoverage.getExpansions(); auto SubView = |

