diff options
| author | Dehao Chen <dehao@google.com> | 2017-04-10 20:49:16 +0000 |
|---|---|---|
| committer | Dehao Chen <dehao@google.com> | 2017-04-10 20:49:16 +0000 |
| commit | d4a3397861f13e912f77371853964ff747a178cf (patch) | |
| tree | 96376f872033d8b00b03794728518f5878183758 /llvm | |
| parent | 635e5056752adeca6bf5a609621a5cc5b0929130 (diff) | |
| download | bcm5719-llvm-d4a3397861f13e912f77371853964ff747a178cf.tar.gz bcm5719-llvm-d4a3397861f13e912f77371853964ff747a178cf.zip | |
Emit less compiler optimization remarks in samplepgo to reduce a call to findCalleeFunctionSamples which is going to be refactored.
Summary: Now the SamplePGO support is more stable, we do not need so many verbose optimization remarks emitted.
Reviewers: dnovillo, davidxl
Reviewed By: davidxl
Subscribers: fhahn, llvm-commits
Differential Revision: https://reviews.llvm.org/D31826
llvm-svn: 299883
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/Transforms/IPO/SampleProfile.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/Transforms/SampleProfile/inline-coverage.ll | 2 | ||||
| -rw-r--r-- | llvm/test/Transforms/SampleProfile/remarks.ll | 2 |
3 files changed, 3 insertions, 5 deletions
diff --git a/llvm/lib/Transforms/IPO/SampleProfile.cpp b/llvm/lib/Transforms/IPO/SampleProfile.cpp index d2ccbd811ba..bae08d9b9ee 100644 --- a/llvm/lib/Transforms/IPO/SampleProfile.cpp +++ b/llvm/lib/Transforms/IPO/SampleProfile.cpp @@ -664,13 +664,11 @@ bool SampleProfileLoader::inlineHotFunctions( continue; } DebugLoc DLoc = I->getDebugLoc(); - uint64_t NumSamples = findCalleeFunctionSamples(*I)->getTotalSamples(); if (InlineFunction(CallSite(DI), IFI)) { LocalChanged = true; emitOptimizationRemark(Ctx, DEBUG_TYPE, F, DLoc, Twine("inlined hot callee '") + - CalledFunction->getName() + "' with " + - Twine(NumSamples) + " samples into '" + + CalledFunction->getName() + "' into '" + F.getName() + "'"); } } diff --git a/llvm/test/Transforms/SampleProfile/inline-coverage.ll b/llvm/test/Transforms/SampleProfile/inline-coverage.ll index 72100ac6f5d..080876a4647 100644 --- a/llvm/test/Transforms/SampleProfile/inline-coverage.ll +++ b/llvm/test/Transforms/SampleProfile/inline-coverage.ll @@ -16,7 +16,7 @@ ; 11 return sum > 0 ? 0 : 1; ; 12 } ; -; CHECK: remark: coverage.cc:10:12: inlined hot callee '_Z3fool' with 172746 samples into 'main' +; CHECK: remark: coverage.cc:10:12: inlined hot callee '_Z3fool' into 'main' ; CHECK: remark: coverage.cc:9:21: Applied 23478 samples from profile (offset: 2.1) ; CHECK: remark: coverage.cc:10:16: Applied 23478 samples from profile (offset: 3) ; CHECK: remark: coverage.cc:4:10: Applied 31878 samples from profile (offset: 1) diff --git a/llvm/test/Transforms/SampleProfile/remarks.ll b/llvm/test/Transforms/SampleProfile/remarks.ll index 4be043e8268..dfb075ee00e 100644 --- a/llvm/test/Transforms/SampleProfile/remarks.ll +++ b/llvm/test/Transforms/SampleProfile/remarks.ll @@ -19,7 +19,7 @@ ; We are expecting foo() to be inlined in main() (almost all the cycles are ; spent inside foo). -; CHECK: remark: remarks.cc:13:21: inlined hot callee '_Z3foov' with 623868 samples into 'main' +; CHECK: remark: remarks.cc:13:21: inlined hot callee '_Z3foov' into 'main' ; The back edge for the loop is the hottest edge in the loop subgraph. ; CHECK: remark: remarks.cc:6:9: most popular destination for conditional branches at remarks.cc:5:3 |
