diff options
| author | Manuel Klimek <klimek@google.com> | 2013-06-03 13:03:05 +0000 |
|---|---|---|
| committer | Manuel Klimek <klimek@google.com> | 2013-06-03 13:03:05 +0000 |
| commit | d0cf5b2de355cb5ec6ec90a7057f60a4d2a10169 (patch) | |
| tree | 0581e56a7d4225f3ab3d1f21acc608dcfbc81b9d /llvm | |
| parent | 17ee1abfa7a093fea959037f668e8bb8c67c5f19 (diff) | |
| download | bcm5719-llvm-d0cf5b2de355cb5ec6ec90a7057f60a4d2a10169.tar.gz bcm5719-llvm-d0cf5b2de355cb5ec6ec90a7057f60a4d2a10169.zip | |
Introduce needsCleanup() for APFloat and APInt.
This is needed in clang so one can check if the object needs the
destructor called after its memory was freed. This is useful when
creating many APInt/APFloat objects with placement new, where the
overhead of tracking the pointers for cleanup is significant.
llvm-svn: 183100
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/include/llvm/ADT/APFloat.h | 3 | ||||
| -rw-r--r-- | llvm/include/llvm/ADT/APInt.h | 5 | ||||
| -rw-r--r-- | llvm/lib/Support/APFloat.cpp | 2 |
3 files changed, 8 insertions, 2 deletions
diff --git a/llvm/include/llvm/ADT/APFloat.h b/llvm/include/llvm/ADT/APFloat.h index 64e56a0ef6a..33f997e1734 100644 --- a/llvm/include/llvm/ADT/APFloat.h +++ b/llvm/include/llvm/ADT/APFloat.h @@ -201,6 +201,9 @@ public: /// @} + /// \brief Returns whether this instance allocated memory. + bool needsCleanup() const { return partCount() > 1; } + /// \name Convenience "constructors" /// @{ diff --git a/llvm/include/llvm/ADT/APInt.h b/llvm/include/llvm/ADT/APInt.h index a9df4036be2..e5797b8be23 100644 --- a/llvm/include/llvm/ADT/APInt.h +++ b/llvm/include/llvm/ADT/APInt.h @@ -293,7 +293,7 @@ public: /// \brief Destructor. ~APInt() { - if (!isSingleWord()) + if (needsCleanup()) delete[] pVal; } @@ -303,6 +303,9 @@ public: /// method Read). explicit APInt() : BitWidth(1) {} + /// \brief Returns whether this instance allocated memory. + bool needsCleanup() const { return !isSingleWord(); } + /// Used to insert APInt objects, or objects that contain APInt objects, into /// FoldingSets. void Profile(FoldingSetNodeID &id) const; diff --git a/llvm/lib/Support/APFloat.cpp b/llvm/lib/Support/APFloat.cpp index 16586fbc9e8..2ad66c5687c 100644 --- a/llvm/lib/Support/APFloat.cpp +++ b/llvm/lib/Support/APFloat.cpp @@ -580,7 +580,7 @@ APFloat::initialize(const fltSemantics *ourSemantics) void APFloat::freeSignificand() { - if (partCount() > 1) + if (needsCleanup()) delete [] significand.parts; } |

