diff options
| author | Jordan Rupprecht <rupprecht@google.com> | 2018-10-30 16:23:38 +0000 |
|---|---|---|
| committer | Jordan Rupprecht <rupprecht@google.com> | 2018-10-30 16:23:38 +0000 |
| commit | 634820d414acd9708b65b72af48e90355c631737 (patch) | |
| tree | b5e4a04f76454bdaf26397e13fafbcddf725eadf /llvm/tools | |
| parent | 68a61cb07c202192c6c48bc82f2522eb3a5491fb (diff) | |
| download | bcm5719-llvm-634820d414acd9708b65b72af48e90355c631737.tar.gz bcm5719-llvm-634820d414acd9708b65b72af48e90355c631737.zip | |
[llvm-objcopy] Fix --keep-global-symbol/--globalize-symbol for undefined symbols.
Summary: --keep-global-symbol and --globalize-symbol don't make sense for undefined symbols, so it should be ignored for those symbols. This matches GNU objcopy behavior.
Reviewers: jhenderson, alexshap, jakehehrlich, espindola
Reviewed By: jhenderson, jakehehrlich
Subscribers: emaste, arichardson, llvm-commits
Differential Revision: https://reviews.llvm.org/D53733
llvm-svn: 345614
Diffstat (limited to 'llvm/tools')
| -rw-r--r-- | llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp b/llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp index 76379788205..2bad270cda7 100644 --- a/llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp +++ b/llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp @@ -230,11 +230,13 @@ static void handleArgs(const CopyConfig &Config, Object &Obj, // --keep-global-symbol. Because of that, make sure to check // --globalize-symbol second. if (!Config.SymbolsToKeepGlobal.empty() && - !is_contained(Config.SymbolsToKeepGlobal, Sym.Name)) + !is_contained(Config.SymbolsToKeepGlobal, Sym.Name) && + Sym.getShndx() != SHN_UNDEF) Sym.Binding = STB_LOCAL; if (!Config.SymbolsToGlobalize.empty() && - is_contained(Config.SymbolsToGlobalize, Sym.Name)) + is_contained(Config.SymbolsToGlobalize, Sym.Name) && + Sym.getShndx() != SHN_UNDEF) Sym.Binding = STB_GLOBAL; if (!Config.SymbolsToWeaken.empty() && |
