diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2018-08-07 19:55:12 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2018-08-07 19:55:12 +0000 |
| commit | 875f6dae86059761f5e9d7cad5a5c698585fa33d (patch) | |
| tree | 789b406fbed20575c0de7207de3acf05aa1d7292 /llvm/tools/msbuild | |
| parent | 50976393ed8734e043bed2351ef274e1670dc96e (diff) | |
| download | bcm5719-llvm-875f6dae86059761f5e9d7cad5a5c698585fa33d.tar.gz bcm5719-llvm-875f6dae86059761f5e9d7cad5a5c698585fa33d.zip | |
Update msbuild integration warnings: Don't warn on /Zi and /X
We do need to map /Zi to /Z7 explicitly for msbuild as explained in this file,
but since /Zi is passed by default and since things transparently work fine
with it mapped to /Z7, we shouldn't produce effectively inactionable noise for
it.
Also don't warn on /X since clang-cl supports that (since r326357; the risk of
duplicating a bunch of clang-cl driver logic here).
https://reviews.llvm.org/D50398
llvm-svn: 339169
Diffstat (limited to 'llvm/tools/msbuild')
| -rw-r--r-- | llvm/tools/msbuild/LLVM.Cpp.Common.targets | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/llvm/tools/msbuild/LLVM.Cpp.Common.targets b/llvm/tools/msbuild/LLVM.Cpp.Common.targets index 1edc08d2a32..e0f2bbbe72f 100644 --- a/llvm/tools/msbuild/LLVM.Cpp.Common.targets +++ b/llvm/tools/msbuild/LLVM.Cpp.Common.targets @@ -40,10 +40,7 @@ to look at the tool output. --> <Target Name="BeforeClCompile" BeforeTargets="ClCompile"> - <!-- Warn on /Zi and /ZI, then map them both to /Z7. --> - <Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'ProgramDatabase'" - File="@(ClCompile)(0,0)" - Text="clang-cl does not support /Zi (Program Database). The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed. Update the Debug Information Format in project settings to silence this warning."/> + <!-- Warn on /ZI, then map to /Z7. /Zi is mapped to /Z7 below too (see comment there), but don't warn on that. --> <Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'EditAndContinue'" File="@(ClCompile)(0,0)" Text="clang-cl does not support /ZI (Program Database for Edit and Continue). The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed. Update the Debug Information Format in project settings to silence this warning."/> @@ -58,11 +55,6 @@ File="@(ClCompile)(0,0)" Text="clang-cl does not support MSVC Link Time Optimization. Disable this option in compatibility settings to silence this warning."/> - <!-- Warn if Ignore Standard Include Paths is non-empty, then ignore it. --> - <Warning Condition="'%(ClCompile.IgnoreStandardIncludePath)' == 'true'" - File="@(ClCompile)(0,0)" - Text="clang-cl does not support Ignore Standard Include Path (/X). Disable this option in compatibility settings to silence this warning."/> - <!-- Warn if Smaller Type Check is enabled, then ignore it.--> <Warning Condition="'%(ClCompile.SmallerTypeCheck)' == 'true'" File="@(ClCompile)(0,0)" |
