diff options
| author | Taewook Oh <twoh@fb.com> | 2018-04-25 17:19:21 +0000 |
|---|---|---|
| committer | Taewook Oh <twoh@fb.com> | 2018-04-25 17:19:21 +0000 |
| commit | 923c216da572e93dc732478a2cad59929ec7c544 (patch) | |
| tree | 2c213822cdd90850e1dd2d9285af05d5a78c8c8b /llvm/tools/llvm-xray/xray-graph-diff.h | |
| parent | 79c6ec484eb0a6dcf9b0aec92174745f094e8d23 (diff) | |
| download | bcm5719-llvm-923c216da572e93dc732478a2cad59929ec7c544.tar.gz bcm5719-llvm-923c216da572e93dc732478a2cad59929ec7c544.zip | |
[ICP] Do not attempt type matching for variable length arguments.
Summary:
When performing indirect call promotion, current implementation inspects "all" parameters of the callsite and attemps to match with the formal argument type of the callee function. However, it is not possible to find the type for variable length arguments, and the compiler crashes when it attemps to match the type for variable lenght argument.
It seems that the bug is introduced with D40658. Prior to that, the type matching is performed only for the parameters whose ID is less than callee->getFunctionNumParams(). The attached test case will crash without the patch.
Reviewers: mssimpso, davidxl, davide
Reviewed By: mssimpso
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D46026
llvm-svn: 330844
Diffstat (limited to 'llvm/tools/llvm-xray/xray-graph-diff.h')
0 files changed, 0 insertions, 0 deletions
