diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-11-13 07:54:05 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-11-13 07:54:05 +0000 |
| commit | e0eb086dd426cc1d2e708653f0b48edae40aa600 (patch) | |
| tree | 6d351b57449372420eac65a97636325b8734fe99 /llvm/tools/llvm-readobj/llvm-readobj.cpp | |
| parent | 1e783024d3510cc55c3fd49f5ba0e45faea39fd6 (diff) | |
| download | bcm5719-llvm-e0eb086dd426cc1d2e708653f0b48edae40aa600.tar.gz bcm5719-llvm-e0eb086dd426cc1d2e708653f0b48edae40aa600.zip | |
llvm-readobj: relocAddressLess could potentially lie
On error conditions, relocAddressLess might claim that a value is less
than itself. Instead, abort llvm-readobj. No functionality change
intended.
llvm-svn: 221872
Diffstat (limited to 'llvm/tools/llvm-readobj/llvm-readobj.cpp')
| -rw-r--r-- | llvm/tools/llvm-readobj/llvm-readobj.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/tools/llvm-readobj/llvm-readobj.cpp b/llvm/tools/llvm-readobj/llvm-readobj.cpp index 55eadd887c7..6d05658c07c 100644 --- a/llvm/tools/llvm-readobj/llvm-readobj.cpp +++ b/llvm/tools/llvm-readobj/llvm-readobj.cpp @@ -168,8 +168,8 @@ bool error(std::error_code EC) { bool relocAddressLess(RelocationRef a, RelocationRef b) { uint64_t a_addr, b_addr; - if (error(a.getOffset(a_addr))) return false; - if (error(b.getOffset(b_addr))) return false; + if (error(a.getOffset(a_addr))) exit(ReturnValue); + if (error(b.getOffset(b_addr))) exit(ReturnValue); return a_addr < b_addr; } |
