summaryrefslogtreecommitdiffstats
path: root/llvm/tools/llvm-readobj/COFFDumper.cpp
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2015-06-29 23:29:12 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2015-06-29 23:29:12 +0000
commit96d071cd0ccc53bbf94bcd6ed4b52c9006b17e15 (patch)
tree23fbac45fb7ee7c71bcb7d3207e4ee6bea0c14b4 /llvm/tools/llvm-readobj/COFFDumper.cpp
parent79cfd437b5fcb71d4b748831db888c700231c0c4 (diff)
downloadbcm5719-llvm-96d071cd0ccc53bbf94bcd6ed4b52c9006b17e15.tar.gz
bcm5719-llvm-96d071cd0ccc53bbf94bcd6ed4b52c9006b17e15.zip
Don't return error_code from function that never fails.
llvm-svn: 241021
Diffstat (limited to 'llvm/tools/llvm-readobj/COFFDumper.cpp')
-rw-r--r--llvm/tools/llvm-readobj/COFFDumper.cpp8
1 files changed, 2 insertions, 6 deletions
diff --git a/llvm/tools/llvm-readobj/COFFDumper.cpp b/llvm/tools/llvm-readobj/COFFDumper.cpp
index 0041c7ef6a9..1b8bdbe2ace 100644
--- a/llvm/tools/llvm-readobj/COFFDumper.cpp
+++ b/llvm/tools/llvm-readobj/COFFDumper.cpp
@@ -121,9 +121,7 @@ std::error_code COFFDumper::resolveSymbol(const coff_section *Section,
uint64_t Offset, SymbolRef &Sym) {
const auto &Relocations = RelocMap[Section];
for (const auto &Relocation : Relocations) {
- uint64_t RelocationOffset;
- if (std::error_code EC = Relocation.getOffset(RelocationOffset))
- return EC;
+ uint64_t RelocationOffset = Relocation.getOffset();
if (RelocationOffset == Offset) {
Sym = *Relocation.getSymbol();
@@ -805,12 +803,10 @@ void COFFDumper::printRelocations() {
void COFFDumper::printRelocation(const SectionRef &Section,
const RelocationRef &Reloc) {
- uint64_t Offset;
+ uint64_t Offset = Reloc.getOffset();
uint64_t RelocType;
SmallString<32> RelocName;
StringRef SymbolName;
- if (error(Reloc.getOffset(Offset)))
- return;
if (error(Reloc.getType(RelocType)))
return;
if (error(Reloc.getTypeName(RelocName)))
OpenPOWER on IntegriCloud