diff options
| author | Paul Semel <semelpaul@gmail.com> | 2018-06-01 16:19:46 +0000 |
|---|---|---|
| committer | Paul Semel <semelpaul@gmail.com> | 2018-06-01 16:19:46 +0000 |
| commit | 46201fb7bc31ed90409440878ccbe567efd33cd8 (patch) | |
| tree | cb0ead3bb6726309d2af8700d78e060e2dbb697a /llvm/tools/llvm-objcopy/llvm-objcopy.cpp | |
| parent | bc68385dad322f80a5b064db2f4e0fd3f9c21781 (diff) | |
| download | bcm5719-llvm-46201fb7bc31ed90409440878ccbe567efd33cd8.tar.gz bcm5719-llvm-46201fb7bc31ed90409440878ccbe567efd33cd8.zip | |
[llvm-objcopy] Fix null symbol handling
This fixes the bug where strip-all option was
leading to a malformed outputted ELF file.
Differential Revision: https://reviews.llvm.org/D47414
llvm-svn: 333772
Diffstat (limited to 'llvm/tools/llvm-objcopy/llvm-objcopy.cpp')
| -rw-r--r-- | llvm/tools/llvm-objcopy/llvm-objcopy.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/llvm/tools/llvm-objcopy/llvm-objcopy.cpp b/llvm/tools/llvm-objcopy/llvm-objcopy.cpp index bbd21d58823..0563af93290 100644 --- a/llvm/tools/llvm-objcopy/llvm-objcopy.cpp +++ b/llvm/tools/llvm-objcopy/llvm-objcopy.cpp @@ -292,9 +292,7 @@ void HandleArgs(const CopyConfig &Config, Object &Obj, const Reader &Reader, return true; } - // TODO: We might handle the 'null symbol' in a different way - // by probably handling it the same way as we handle 'null section' ? - if (Config.StripUnneeded && !Sym.Referenced && Sym.Index != 0 && + if (Config.StripUnneeded && !Sym.Referenced && (Sym.Binding == STB_LOCAL || Sym.getShndx() == SHN_UNDEF) && Sym.Type != STT_FILE && Sym.Type != STT_SECTION) return true; |
