diff options
| author | Hans Wennborg <hans@hanshq.net> | 2019-06-27 13:55:02 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2019-06-27 13:55:02 +0000 |
| commit | 408fc0849ea1f630baa85d5bf78ee359c52585e1 (patch) | |
| tree | dbfa29e95e14e44ac8b3760553a47285cf73d5d5 /llvm/test | |
| parent | a0d45058ebb39dc18cbcdcba01d11d36eca001be (diff) | |
| download | bcm5719-llvm-408fc0849ea1f630baa85d5bf78ee359c52585e1.tar.gz bcm5719-llvm-408fc0849ea1f630baa85d5bf78ee359c52585e1.zip | |
Revert r363658 "[SVE][IR] Scalable Vector IR Type with pr42210 fix"
We saw a 70% ThinLTO link time increase in Chromium for Android, see
crbug.com/978817. Sounds like more of PR42210.
> Recommit of D32530 with a few small changes:
> - Stopped recursively walking through aggregates in
> the verifier, so that we don't impose too much
> overhead on large modules under LTO (see PR42210).
> - Changed tests to match; the errors are slightly
> different since they only report the array or
> struct that actually contains a scalable vector,
> rather than all aggregates which contain one in
> a nested member.
> - Corrected an older comment
>
> Reviewers: thakis, rengolin, sdesmalen
>
> Reviewed By: sdesmalen
>
> Differential Revision: https://reviews.llvm.org/D63321
llvm-svn: 364543
Diffstat (limited to 'llvm/test')
| -rw-r--r-- | llvm/test/Bitcode/compatibility.ll | 4 | ||||
| -rw-r--r-- | llvm/test/Verifier/scalable-aggregates.ll | 27 | ||||
| -rw-r--r-- | llvm/test/Verifier/scalable-global-vars.ll | 26 |
3 files changed, 0 insertions, 57 deletions
diff --git a/llvm/test/Bitcode/compatibility.ll b/llvm/test/Bitcode/compatibility.ll index 991bde69b61..19a6cb0acc1 100644 --- a/llvm/test/Bitcode/compatibility.ll +++ b/llvm/test/Bitcode/compatibility.ll @@ -917,10 +917,6 @@ define void @typesystem() { ; CHECK: %t7 = alloca x86_mmx %t8 = alloca %opaquety* ; CHECK: %t8 = alloca %opaquety* - %t9 = alloca <4 x i32> - ; CHECK: %t9 = alloca <4 x i32> - %t10 = alloca <vscale x 4 x i32> - ; CHECK: %t10 = alloca <vscale x 4 x i32> ret void } diff --git a/llvm/test/Verifier/scalable-aggregates.ll b/llvm/test/Verifier/scalable-aggregates.ll deleted file mode 100644 index aac3018cf16..00000000000 --- a/llvm/test/Verifier/scalable-aggregates.ll +++ /dev/null @@ -1,27 +0,0 @@ -; RUN: not opt -S -verify < %s 2>&1 | FileCheck %s - -;; Arrays and Structs cannot contain scalable vectors, since we don't -;; know the size at compile time and the container types need to have -;; a known size. - -; CHECK-DAG: Arrays cannot contain scalable vectors -; CHECK-DAG: [4 x <vscale x 256 x i1>]; ModuleID = '<stdin>' -; CHECK-DAG: Arrays cannot contain scalable vectors -; CHECK-DAG: [2 x <vscale x 4 x i32>]; ModuleID = '<stdin>' -; CHECK-DAG: Structs cannot contain scalable vectors -; CHECK-DAG: { i32, <vscale x 1 x i32> }; ModuleID = '<stdin>' -;; CHECK-DAG: Structs cannot contain scalable vectors -; CHECK-DAG: { <vscale x 16 x i8>, <vscale x 2 x double> }; ModuleID = '<stdin>' -; CHECK-DAG: Structs cannot contain scalable vectors -; CHECK-DAG: %sty = type { i64, <vscale x 32 x i16> }; ModuleID = '<stdin>' - -%sty = type { i64, <vscale x 32 x i16> } - -define void @scalable_aggregates() { - %array = alloca [2 x <vscale x 4 x i32>] - %struct = alloca { <vscale x 16 x i8>, <vscale x 2 x double> } - %named_struct = alloca %sty - %s_in_a = alloca [2 x { i32, <vscale x 1 x i32> } ] - %a_in_s = alloca { i64, [4 x <vscale x 256 x i1> ] } - ret void -}
\ No newline at end of file diff --git a/llvm/test/Verifier/scalable-global-vars.ll b/llvm/test/Verifier/scalable-global-vars.ll deleted file mode 100644 index 73b79ab6157..00000000000 --- a/llvm/test/Verifier/scalable-global-vars.ll +++ /dev/null @@ -1,26 +0,0 @@ -; RUN: not opt -S -verify < %s 2>&1 | FileCheck %s - -;; Global variables cannot be scalable vectors, since we don't -;; know the size at compile time. - -; CHECK: Globals cannot contain scalable vectors -; CHECK-NEXT: <vscale x 4 x i32>* @ScalableVecGlobal -@ScalableVecGlobal = global <vscale x 4 x i32> zeroinitializer - -;; Global _pointers_ to scalable vectors are fine -; CHECK-NOT: Globals cannot contain scalable vectors -@ScalableVecPtr = global <vscale x 8 x i16>* zeroinitializer - -;; The following errors don't explicitly mention global variables, but -;; do still guarantee that the error will be caught. -; CHECK-DAG: Arrays cannot contain scalable vectors -; CHECK-DAG: [64 x <vscale x 2 x double>]; ModuleID = '<stdin>' -@ScalableVecGlobalArray = global [64 x <vscale x 2 x double>] zeroinitializer - -; CHECK-DAG: Structs cannot contain scalable vectors -; CHECK-DAG: { <vscale x 16 x i64>, <vscale x 16 x i1> }; ModuleID = '<stdin>' -@ScalableVecGlobalStruct = global { <vscale x 16 x i64>, <vscale x 16 x i1> } zeroinitializer - -; CHECK-DAG: Structs cannot contain scalable vectors -; CHECK-DAG { <vscale x 4 x i64>, <vscale x 32 x i8> }; ModuleID = '<stdin>' -@ScalableVecMixed = global { [4 x i32], [2 x { <vscale x 4 x i64>, <vscale x 32 x i8> }]} zeroinitializer |

