diff options
| author | Fangrui Song <maskray@google.com> | 2018-06-23 00:15:33 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2018-06-23 00:15:33 +0000 |
| commit | 4ef42a83f9b1068917ff0f3eebdc39a0e99a4846 (patch) | |
| tree | 7632efa2bf330126296dcee5d4f49310d755c9c2 /llvm/test/Object/objdump-sectionheaders.test | |
| parent | e737e754915f9c35ab1ec75570070b9438833f2c (diff) | |
| download | bcm5719-llvm-4ef42a83f9b1068917ff0f3eebdc39a0e99a4846.tar.gz bcm5719-llvm-4ef42a83f9b1068917ff0f3eebdc39a0e99a4846.zip | |
[ELF] Change isSectionData to exclude SHF_EXECINSTR
Summary:
This affects what sections are displayed as "DATA" in llvm-objdump.
The other user llvm-size is unaffected.
Before, a "TEXT" section is also "DATA", which seems weird.
The sh_flags condition matches that of bfd's SEC_DATA but the sh_type
condition uses (== SHF_PROGBITS) instead of bfd's (!= SHT_NOBITS).
bfd's SEC_DATA is not appealing as so many sections will be shown as DATA.
Reviewers: jyknight, Bigcheese
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D48472
llvm-svn: 335405
Diffstat (limited to 'llvm/test/Object/objdump-sectionheaders.test')
| -rw-r--r-- | llvm/test/Object/objdump-sectionheaders.test | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/test/Object/objdump-sectionheaders.test b/llvm/test/Object/objdump-sectionheaders.test index bc2478cea2f..efdd6bb5fc9 100644 --- a/llvm/test/Object/objdump-sectionheaders.test +++ b/llvm/test/Object/objdump-sectionheaders.test @@ -7,7 +7,7 @@ ; CHECK: Sections: ; CHECK: Idx Name Size Address Type ; CHECK: 0 00000000 0000000000000000 -; CHECK: 1 .text 00000026 0000000000000000 TEXT DATA +; CHECK: 1 .text 00000026 0000000000000000 TEXT ; CHECK: 2 .rodata.str1.1 0000000d 0000000000000026 DATA ; CHECK: 3 .note.GNU-stack 00000000 0000000000000033 ; CHECK: 4 .rela.text 00000048 0000000000000038 |
