diff options
| author | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
|---|---|---|
| committer | Kuba Mracek <mracek@apple.com> | 2017-08-15 20:29:24 +0000 |
| commit | 17ee427ef35d7521f90f28a7db83fddb4aadd475 (patch) | |
| tree | 0d63ef2fcb684b5fbddf5e45cca3acfded4af8b6 /llvm/test/LibDriver/libpath.test | |
| parent | cea6267cc6114bc3ee89e66ede36239841d813c0 (diff) | |
| download | bcm5719-llvm-17ee427ef35d7521f90f28a7db83fddb4aadd475.tar.gz bcm5719-llvm-17ee427ef35d7521f90f28a7db83fddb4aadd475.zip | |
[llvm] Get rid of "%T" expansions
The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.
This patch removes %T in llvm.
Differential Revision: https://reviews.llvm.org/D36495
llvm-svn: 310953
Diffstat (limited to 'llvm/test/LibDriver/libpath.test')
| -rw-r--r-- | llvm/test/LibDriver/libpath.test | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/llvm/test/LibDriver/libpath.test b/llvm/test/LibDriver/libpath.test index 2cfca2456d9..26a1e8dc8b6 100644 --- a/llvm/test/LibDriver/libpath.test +++ b/llvm/test/LibDriver/libpath.test @@ -1,14 +1,14 @@ -RUN: mkdir -p %T/a %T/b -RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %T/a/foo.obj %S/Inputs/a.s -RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %T/b/foo.obj %S/Inputs/b.s +RUN: mkdir -p %t/a %t/b +RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a/foo.obj %S/Inputs/a.s +RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b/foo.obj %S/Inputs/b.s -RUN: env "LIB=%T/a;%T/b" llvm-lib /out:%t1.lib foo.obj +RUN: env "LIB=%t/a;%t/b" llvm-lib /out:%t1.lib foo.obj RUN: llvm-nm %t1.lib | FileCheck --check-prefix=A %s -RUN: llvm-lib /out:%t2.lib /libpath:%T/a /libpath:%T/b foo.obj +RUN: llvm-lib /out:%t2.lib /libpath:%t/a /libpath:%t/b foo.obj RUN: llvm-nm %t2.lib | FileCheck --check-prefix=A %s -RUN: env LIB=%T/a llvm-lib /libpath:%T/b /out:%t3.lib foo.obj +RUN: env LIB=%t/a llvm-lib /libpath:%t/b /out:%t3.lib foo.obj RUN: llvm-nm %t3.lib | FileCheck --check-prefix=B %s A: T a |

