diff options
| author | Arnold Schwaighofer <aschwaighofer@apple.com> | 2014-01-03 05:47:03 +0000 |
|---|---|---|
| committer | Arnold Schwaighofer <aschwaighofer@apple.com> | 2014-01-03 05:47:03 +0000 |
| commit | 833a82ecde7be5ccf58ae951f3c2a8d8e2948101 (patch) | |
| tree | 7d6af5359c6c1ede2a139562acbcfbc3ed1d5f5f /llvm/test/Analysis/GlobalsModRef | |
| parent | 90e5fff1d2a4f4a2506754fdb5ae8d8c3ed7f6da (diff) | |
| download | bcm5719-llvm-833a82ecde7be5ccf58ae951f3c2a8d8e2948101.tar.gz bcm5719-llvm-833a82ecde7be5ccf58ae951f3c2a8d8e2948101.zip | |
BasicAA: Use reachabilty instead of dominance for checking value equality in phi
cycles
This allows the value equality check to work even if we don't have a dominator
tree. Also add some more comments.
I was worried about compile time impacts and did not implement reachability but
used the dominance check in the initial patch. The trade-off was that the
dominator tree was required.
The llvm utility function isPotentiallyReachable cuts off the recursive search
after 32 visits. Testing did not show any compile time regressions showing my
worries unjustfied.
No compile time or performance regressions at O3 -flto -mavx on test-suite +
externals.
Addresses review comments from r198290.
llvm-svn: 198400
Diffstat (limited to 'llvm/test/Analysis/GlobalsModRef')
| -rw-r--r-- | llvm/test/Analysis/GlobalsModRef/aliastest.ll | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/test/Analysis/GlobalsModRef/aliastest.ll b/llvm/test/Analysis/GlobalsModRef/aliastest.ll index 864c516ec95..4cfed71bfb7 100644 --- a/llvm/test/Analysis/GlobalsModRef/aliastest.ll +++ b/llvm/test/Analysis/GlobalsModRef/aliastest.ll @@ -1,4 +1,4 @@ -; RUN: opt < %s -domtree -basicaa -globalsmodref-aa -gvn -S | FileCheck %s +; RUN: opt < %s -basicaa -globalsmodref-aa -gvn -S | FileCheck %s @X = internal global i32 4 ; <i32*> [#uses=1] |
