diff options
| author | Misha Brukman <brukman+llvm@gmail.com> | 2004-03-12 00:58:41 +0000 |
|---|---|---|
| committer | Misha Brukman <brukman+llvm@gmail.com> | 2004-03-12 00:58:41 +0000 |
| commit | 96d3b0a6de087736a1687c564c15a3767f46df54 (patch) | |
| tree | 68fc6e189d0ae72009c5a797d8aab493432d3f0e /llvm/lib | |
| parent | 1df51ed4e5a342da69d3f9ceb3c6bde00d085019 (diff) | |
| download | bcm5719-llvm-96d3b0a6de087736a1687c564c15a3767f46df54.tar.gz bcm5719-llvm-96d3b0a6de087736a1687c564c15a3767f46df54.zip | |
Make code more readable.
llvm-svn: 12305
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Analysis/IPA/MemoryDepAnalysis.cpp | 66 |
1 files changed, 31 insertions, 35 deletions
diff --git a/llvm/lib/Analysis/IPA/MemoryDepAnalysis.cpp b/llvm/lib/Analysis/IPA/MemoryDepAnalysis.cpp index 2bc8e4ac272..97bc9816031 100644 --- a/llvm/lib/Analysis/IPA/MemoryDepAnalysis.cpp +++ b/llvm/lib/Analysis/IPA/MemoryDepAnalysis.cpp @@ -53,7 +53,7 @@ namespace llvm { struct ModRefTable { typedef hash_map<Instruction*, ModRefInfo> ModRefMap; typedef ModRefMap::const_iterator const_map_iterator; - typedef ModRefMap:: iterator map_iterator; + typedef ModRefMap:: iterator map_iterator; typedef std::vector<Instruction*>::const_iterator const_ref_iterator; typedef std::vector<Instruction*>:: iterator ref_iterator; @@ -131,9 +131,9 @@ class ModRefInfoBuilder : public InstVisitor<ModRefInfoBuilder> { void operator=(const ModRefInfoBuilder&); // DO NOT IMPLEMENT public: - /*ctor*/ ModRefInfoBuilder(const DSGraph& _funcGraph, - const FunctionModRefInfo& _funcModRef, - ModRefTable& _modRefTable) + ModRefInfoBuilder(const DSGraph& _funcGraph, + const FunctionModRefInfo& _funcModRef, + ModRefTable& _modRefTable) : funcGraph(_funcGraph), funcModRef(_funcModRef), modRefTable(_modRefTable) { } @@ -142,15 +142,15 @@ public: // Add the call to the defs list if it modifies any nodes and to the uses // list if it refs any nodes. // - void visitCallInst (CallInst& callInst) { + void visitCallInst(CallInst& callInst) { ModRefInfo safeModRef(funcGraph.getGraphSize()); const ModRefInfo* callModRef = funcModRef.getModRefInfo(callInst); - if (callModRef == NULL) - { // call to external/unknown function: mark all nodes as Mod and Ref - safeModRef.getModSet().set(); - safeModRef.getRefSet().set(); - callModRef = &safeModRef; - } + if (callModRef == NULL) { + // call to external/unknown function: mark all nodes as Mod and Ref + safeModRef.getModSet().set(); + safeModRef.getRefSet().set(); + callModRef = &safeModRef; + } modRefTable.modRefMap.insert(std::make_pair(&callInst, ModRefInfo(*callModRef))); @@ -163,40 +163,36 @@ public: // At a store instruction, add to the mod set the single node pointed to // by the pointer argument of the store. Interestingly, if there is no // such node, that would be a null pointer reference! - void visitStoreInst (StoreInst& storeInst) { + void visitStoreInst(StoreInst& storeInst) { const DSNodeHandle& ptrNode = funcGraph.getNodeForValue(storeInst.getPointerOperand()); - if (const DSNode* target = ptrNode.getNode()) - { - unsigned nodeId = funcModRef.getNodeId(target); - ModRefInfo& minfo = - modRefTable.modRefMap.insert( - std::make_pair(&storeInst, - ModRefInfo(funcGraph.getGraphSize()))).first->second; - minfo.setNodeIsMod(nodeId); - modRefTable.AddDef(&storeInst); - } - else + if (const DSNode* target = ptrNode.getNode()) { + unsigned nodeId = funcModRef.getNodeId(target); + ModRefInfo& minfo = + modRefTable.modRefMap.insert( + std::make_pair(&storeInst, + ModRefInfo(funcGraph.getGraphSize()))).first->second; + minfo.setNodeIsMod(nodeId); + modRefTable.AddDef(&storeInst); + } else std::cerr << "Warning: Uninitialized pointer reference!\n"; } // At a load instruction, add to the ref set the single node pointed to // by the pointer argument of the load. Interestingly, if there is no // such node, that would be a null pointer reference! - void visitLoadInst (LoadInst& loadInst) { + void visitLoadInst(LoadInst& loadInst) { const DSNodeHandle& ptrNode = funcGraph.getNodeForValue(loadInst.getPointerOperand()); - if (const DSNode* target = ptrNode.getNode()) - { - unsigned nodeId = funcModRef.getNodeId(target); - ModRefInfo& minfo = - modRefTable.modRefMap.insert( - std::make_pair(&loadInst, - ModRefInfo(funcGraph.getGraphSize()))).first->second; - minfo.setNodeIsRef(nodeId); - modRefTable.AddUse(&loadInst); - } - else + if (const DSNode* target = ptrNode.getNode()) { + unsigned nodeId = funcModRef.getNodeId(target); + ModRefInfo& minfo = + modRefTable.modRefMap.insert( + std::make_pair(&loadInst, + ModRefInfo(funcGraph.getGraphSize()))).first->second; + minfo.setNodeIsRef(nodeId); + modRefTable.AddUse(&loadInst); + } else std::cerr << "Warning: Uninitialized pointer reference!\n"; } }; |

