summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Support/PrettyStackTrace.cpp
diff options
context:
space:
mode:
authorJordan Rose <jordan_rose@apple.com>2018-06-15 16:35:31 +0000
committerJordan Rose <jordan_rose@apple.com>2018-06-15 16:35:31 +0000
commit7e535bc4bff90b0b65d514f3d73384a2fdfd5dc8 (patch)
tree7c1267d60eac215819c6e0a9de9fc3c4665cdca4 /llvm/lib/Support/PrettyStackTrace.cpp
parent68795245cfb3ca1d3c6ddb7e87ed8165de20dbef (diff)
downloadbcm5719-llvm-7e535bc4bff90b0b65d514f3d73384a2fdfd5dc8.tar.gz
bcm5719-llvm-7e535bc4bff90b0b65d514f3d73384a2fdfd5dc8.zip
Avoid copying PrettyStackTrace messages an extra time on Apple OSs
We were unnecessarily going from SmallString to std::string just to get a null-terminated C string. So just...don't do that. Crash slightly faster! llvm-svn: 334841
Diffstat (limited to 'llvm/lib/Support/PrettyStackTrace.cpp')
-rw-r--r--llvm/lib/Support/PrettyStackTrace.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Support/PrettyStackTrace.cpp b/llvm/lib/Support/PrettyStackTrace.cpp
index 9d62d7499dd..f5b6e6f3652 100644
--- a/llvm/lib/Support/PrettyStackTrace.cpp
+++ b/llvm/lib/Support/PrettyStackTrace.cpp
@@ -118,9 +118,9 @@ static void CrashHandler(void *) {
if (!TmpStr.empty()) {
#ifdef HAVE_CRASHREPORTERCLIENT_H
// Cast to void to avoid warning.
- (void)CRSetCrashLogMessage(std::string(TmpStr.str()).c_str());
+ (void)CRSetCrashLogMessage(TmpStr.c_str());
#elif HAVE_CRASHREPORTER_INFO
- __crashreporter_info__ = strdup(std::string(TmpStr.str()).c_str());
+ __crashreporter_info__ = strdup(TmpStr.c_str());
#endif
errs() << TmpStr.str();
}
OpenPOWER on IntegriCloud