diff options
| author | David Blaikie <dblaikie@gmail.com> | 2012-02-09 19:24:12 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2012-02-09 19:24:12 +0000 |
| commit | 18544b96148ffe0232bd5db84eea52ac01ca21c8 (patch) | |
| tree | cf3e09c037d042f8391a623b79da5dede2e3f3bf /llvm/lib/Support/FileUtilities.cpp | |
| parent | b6f7443c3c3ccf39e3936d060d4a197f6d0bd6ef (diff) | |
| download | bcm5719-llvm-18544b96148ffe0232bd5db84eea52ac01ca21c8.tar.gz bcm5719-llvm-18544b96148ffe0232bd5db84eea52ac01ca21c8.zip | |
Change default error_code ctor to a 'named ctor' so it's more self-documenting.
Unify default construction of error_code uses on this idiom so that users don't
feel compelled to make static globals for naming convenience. (unfortunately I
couldn't make the original ctor private as some APIs don't return their result,
instead using an out parameter (that makes sense to default construct) - which
is a bit of a pity. I did, however, find/fix some cases of unnecessary default
construction of error_code before I hit the unfixable cases)
llvm-svn: 150197
Diffstat (limited to 'llvm/lib/Support/FileUtilities.cpp')
| -rw-r--r-- | llvm/lib/Support/FileUtilities.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/llvm/lib/Support/FileUtilities.cpp b/llvm/lib/Support/FileUtilities.cpp index 4c8c0c63ffc..f9e9cf03660 100644 --- a/llvm/lib/Support/FileUtilities.cpp +++ b/llvm/lib/Support/FileUtilities.cpp @@ -200,7 +200,6 @@ int llvm::DiffFilesWithTolerance(const sys::PathWithStatus &FileA, // Now its safe to mmap the files into memory because both files // have a non-zero size. - error_code ec; OwningPtr<MemoryBuffer> F1; if (error_code ec = MemoryBuffer::getFile(FileA.c_str(), F1)) { if (Error) |
