diff options
| author | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-08-24 00:01:19 +0000 |
|---|---|---|
| committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2012-08-24 00:01:19 +0000 |
| commit | 156d92037aab183f8db6b4aac8267612e3f3ec63 (patch) | |
| tree | c2f9058d29c121d5d8cb6f3bede45e7711b5aa5b /llvm/lib/Support/APFloat.cpp | |
| parent | 281d7998b840b3b691fcc8dffa7a1e7b610b4ae4 (diff) | |
| download | bcm5719-llvm-156d92037aab183f8db6b4aac8267612e3f3ec63.tar.gz bcm5719-llvm-156d92037aab183f8db6b4aac8267612e3f3ec63.zip | |
Fix undefined behavior (signed integer overflow) when Clang parses a hexfloat with an enormous exponent. Caught by an existing unit test + -ftrapv.
llvm-svn: 162505
Diffstat (limited to 'llvm/lib/Support/APFloat.cpp')
| -rw-r--r-- | llvm/lib/Support/APFloat.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Support/APFloat.cpp b/llvm/lib/Support/APFloat.cpp index ed261a4194c..f143e6d0ade 100644 --- a/llvm/lib/Support/APFloat.cpp +++ b/llvm/lib/Support/APFloat.cpp @@ -196,8 +196,10 @@ totalExponent(StringRef::iterator p, StringRef::iterator end, assert(value < 10U && "Invalid character in exponent"); unsignedExponent = unsignedExponent * 10 + value; - if (unsignedExponent > 32767) + if (unsignedExponent > 32767) { overflow = true; + break; + } } if (exponentAdjustment > 32767 || exponentAdjustment < -32768) |
