diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-24 13:56:32 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-24 13:56:32 +0000 |
| commit | 2e60ca964ccb6a8531559238b28658e1aa4b0d75 (patch) | |
| tree | 5842ce349e814931985e4734f521de90e0b90913 /llvm/lib/Object/ELFObjectFile.cpp | |
| parent | e8b1f91afb850bdfcd4770caeb6ff9897c33ccbe (diff) | |
| download | bcm5719-llvm-2e60ca964ccb6a8531559238b28658e1aa4b0d75.tar.gz bcm5719-llvm-2e60ca964ccb6a8531559238b28658e1aa4b0d75.zip | |
Pass a unique_ptr<MemoryBuffer> to the constructors in the Binary hierarchy.
Once the objects are constructed, they own the buffer. Passing a unique_ptr
makes that clear.
llvm-svn: 211595
Diffstat (limited to 'llvm/lib/Object/ELFObjectFile.cpp')
| -rw-r--r-- | llvm/lib/Object/ELFObjectFile.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/llvm/lib/Object/ELFObjectFile.cpp b/llvm/lib/Object/ELFObjectFile.cpp index a9165af79d6..7095caf1a6e 100644 --- a/llvm/lib/Object/ELFObjectFile.cpp +++ b/llvm/lib/Object/ELFObjectFile.cpp @@ -34,7 +34,7 @@ ObjectFile::createELFObjectFile(std::unique_ptr<MemoryBuffer> &Obj) { #endif if (MaxAlignment >= 2) R.reset(new ELFObjectFile<ELFType<support::little, 2, false>>( - Obj.release(), EC)); + std::move(Obj), EC)); else return object_error::parse_failed; else if (Ident.first == ELF::ELFCLASS32 && Ident.second == ELF::ELFDATA2MSB) @@ -45,32 +45,32 @@ ObjectFile::createELFObjectFile(std::unique_ptr<MemoryBuffer> &Obj) { else #endif if (MaxAlignment >= 2) - R.reset(new ELFObjectFile<ELFType<support::big, 2, false>>(Obj.release(), + R.reset(new ELFObjectFile<ELFType<support::big, 2, false>>(std::move(Obj), EC)); else return object_error::parse_failed; else if (Ident.first == ELF::ELFCLASS64 && Ident.second == ELF::ELFDATA2MSB) #if !LLVM_IS_UNALIGNED_ACCESS_FAST if (MaxAlignment >= 8) - R.reset( - new ELFObjectFile<ELFType<support::big, 8, true>>(Obj.release(), EC)); + R.reset(new ELFObjectFile<ELFType<support::big, 8, true>>(std::move(Obj), + EC)); else #endif if (MaxAlignment >= 2) - R.reset( - new ELFObjectFile<ELFType<support::big, 2, true>>(Obj.release(), EC)); + R.reset(new ELFObjectFile<ELFType<support::big, 2, true>>(std::move(Obj), + EC)); else return object_error::parse_failed; else if (Ident.first == ELF::ELFCLASS64 && Ident.second == ELF::ELFDATA2LSB) { #if !LLVM_IS_UNALIGNED_ACCESS_FAST if (MaxAlignment >= 8) R.reset(new ELFObjectFile<ELFType<support::little, 8, true>>( - Obj.release(), EC)); + std::move(Obj), EC)); else #endif if (MaxAlignment >= 2) R.reset(new ELFObjectFile<ELFType<support::little, 2, true>>( - Obj.release(), EC)); + std::move(Obj), EC)); else return object_error::parse_failed; } |
