summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Object/COFFYAML.cpp
diff options
context:
space:
mode:
authorHans Wennborg <hans@hanshq.net>2014-06-06 20:04:01 +0000
committerHans Wennborg <hans@hanshq.net>2014-06-06 20:04:01 +0000
commitc94391d3bfb18ed6ec0989fad1cdf66afd1292f7 (patch)
tree79d3f58f5657986f0a5559f71854f6bc9e1c93b3 /llvm/lib/Object/COFFYAML.cpp
parent0766ae08e58cb6358ed1ce407439bd3614380b2e (diff)
downloadbcm5719-llvm-c94391d3bfb18ed6ec0989fad1cdf66afd1292f7.tar.gz
bcm5719-llvm-c94391d3bfb18ed6ec0989fad1cdf66afd1292f7.zip
MS ABI: Update the thunk linkage computation
As suggested by Reid: - class has GVA_Internal linkage -> internal - thunk has return adjustment -> weak_odr, to handle evil corner case [1] - all other normal methods -> linkonce_odr 1. Evil corner case: struct Incomplete; struct A { int a; virtual A *bar(); }; struct B { int b; virtual B *foo(Incomplete); }; struct C : A, B { int c; virtual C *foo(Incomplete); }; C c; Here, the thunk for C::foo() will be emitted when C::foo() is defined, which might be in a different translation unit, so it needs to be weak_odr. Differential Revision: http://reviews.llvm.org/D3992 llvm-svn: 210368
Diffstat (limited to 'llvm/lib/Object/COFFYAML.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud