diff options
| author | Sam Clegg <sbc@chromium.org> | 2018-01-11 23:59:16 +0000 |
|---|---|---|
| committer | Sam Clegg <sbc@chromium.org> | 2018-01-11 23:59:16 +0000 |
| commit | cd65f698082b6055d9b3383c119f6da3d6559643 (patch) | |
| tree | 2cc82bbabb6055c6fae72cc917ce14139d1044eb /llvm/lib/MC/WasmObjectWriter.cpp | |
| parent | f4b08847182873a10e6e027c40da9501c13f679d (diff) | |
| download | bcm5719-llvm-cd65f698082b6055d9b3383c119f6da3d6559643.tar.gz bcm5719-llvm-cd65f698082b6055d9b3383c119f6da3d6559643.zip | |
[WebAssembly] MC: Remove SetUsed argument when calling MCSymbol::isDefined et al
Summary:
This argument (the isUsed flag) seems to only be relevant
when parsing. Other calls sites such as these don't seem
to ever use it.
Subscribers: jfb, dschuff, jgravelle-google, aheejin, sunfish
Differential Revision: https://reviews.llvm.org/D41970
llvm-svn: 322332
Diffstat (limited to 'llvm/lib/MC/WasmObjectWriter.cpp')
| -rw-r--r-- | llvm/lib/MC/WasmObjectWriter.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/llvm/lib/MC/WasmObjectWriter.cpp b/llvm/lib/MC/WasmObjectWriter.cpp index ff000733999..f9f00e1aa4e 100644 --- a/llvm/lib/MC/WasmObjectWriter.cpp +++ b/llvm/lib/MC/WasmObjectWriter.cpp @@ -502,7 +502,7 @@ WasmObjectWriter::getProvisionalValue(const WasmRelocationEntry &RelEntry) { const MCSymbolWasm *Sym = ResolveSymbol(*RelEntry.Symbol); // For undefined symbols, use zero - if (!Sym->isDefined(/*SetUsed=*/false)) + if (!Sym->isDefined()) return 0; uint32_t GlobalIndex = SymbolIndices[Sym]; @@ -1122,7 +1122,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, continue; // If the symbol is not defined in this translation unit, import it. - if ((!WS.isDefined(/*SetUsed=*/false) && !WS.isComdat()) || + if ((!WS.isDefined() && !WS.isComdat()) || WS.isVariable()) { WasmImport Import; Import.ModuleName = WS.getModuleName(); @@ -1206,7 +1206,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, unsigned Index; if (WS.isFunction()) { - if (WS.isDefined(/*SetUsed=*/false)) { + if (WS.isDefined()) { if (WS.getOffset() != 0) report_fatal_error( "function sections must contain one function each"); @@ -1234,7 +1234,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, if (WS.isTemporary() && !WS.getSize()) continue; - if (!WS.isDefined(/*SetUsed=*/false)) + if (!WS.isDefined()) continue; if (!WS.getSize()) @@ -1263,7 +1263,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, } // If the symbol is visible outside this translation unit, export it. - if (WS.isDefined(/*SetUsed=*/false)) { + if (WS.isDefined()) { WasmExport Export; Export.FieldName = WS.getName(); Export.Index = Index; @@ -1278,7 +1278,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, SymbolFlags.emplace_back(WS.getName(), wasm::WASM_SYMBOL_BINDING_LOCAL); if (WS.isFunction()) { - auto &Section = static_cast<MCSectionWasm &>(WS.getSection(false)); + auto &Section = static_cast<MCSectionWasm &>(WS.getSection()); if (const MCSymbolWasm *C = Section.getGroup()) Comdats[C->getName()].emplace_back( WasmComdatEntry{wasm::WASM_COMDAT_FUNCTION, Index}); @@ -1293,7 +1293,7 @@ void WasmObjectWriter::writeObject(MCAssembler &Asm, if (!S.isVariable()) continue; - assert(S.isDefined(/*SetUsed=*/false)); + assert(S.isDefined()); // Find the target symbol of this weak alias and export that index const auto &WS = static_cast<const MCSymbolWasm &>(S); |

