diff options
| author | Zachary Turner <zturner@google.com> | 2017-05-18 15:14:44 +0000 |
|---|---|---|
| committer | Zachary Turner <zturner@google.com> | 2017-05-18 15:14:44 +0000 |
| commit | 5a83fb153f8ee6048311b2f57c505c488b3ad315 (patch) | |
| tree | 4dd164d982ca6a328618b5c024b7bb7917ce3047 /llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp | |
| parent | 657899bad1abb1a93c088949ecdfd9b91ecadb4a (diff) | |
| download | bcm5719-llvm-5a83fb153f8ee6048311b2f57c505c488b3ad315.tar.gz bcm5719-llvm-5a83fb153f8ee6048311b2f57c505c488b3ad315.zip | |
Fix some minor issues in PDB parsing library.
1) Until now I'd never seen a valid PDB where the DBI stream and
the PDB Stream disagreed on the "Age" field. Because of that,
we had code to assert that they matched. Recently though I was
given a PDB where they disagreed, so this assumption has proven
to be incorrect. Remove this check.
2) We were walking the entire list of hash values for types up front
and then throwing away the values. For large PDBs this was a
significant slow down. Remove this.
With this patch, I can dump the list of all compilands from a
1.5GB PDB file in just a few seconds.
llvm-svn: 303351
Diffstat (limited to 'llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp')
| -rw-r--r-- | llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp b/llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp index f7538c580ba..2f4fb6cc295 100644 --- a/llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp +++ b/llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp @@ -72,14 +72,6 @@ Error DbiStream::reload() { return make_error<RawError>(raw_error_code::feature_unsupported, "Unsupported DBI version."); - auto IS = Pdb.getPDBInfoStream(); - if (!IS) - return IS.takeError(); - - if (Header->Age != IS->getAge()) - return make_error<RawError>(raw_error_code::corrupt_file, - "DBI Age does not match PDB Age."); - if (Stream->getLength() != sizeof(DbiStreamHeader) + Header->ModiSubstreamSize + Header->SecContrSubstreamSize + Header->SectionMapSize + |

