diff options
| author | Adrian McCarthy <amccarth@google.com> | 2017-06-22 18:42:23 +0000 |
|---|---|---|
| committer | Adrian McCarthy <amccarth@google.com> | 2017-06-22 18:42:23 +0000 |
| commit | 6a4b080a5f10f873e163eb526e499a75accea3a2 (patch) | |
| tree | a548408d6e9a9bd0c3034a99247d587e6c5c8b8e /llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp | |
| parent | 41a34e411164468818aad59000f41fce9ccbe018 (diff) | |
| download | bcm5719-llvm-6a4b080a5f10f873e163eb526e499a75accea3a2.tar.gz bcm5719-llvm-6a4b080a5f10f873e163eb526e499a75accea3a2.zip | |
Make IPDBSession::getGlobalScope a non-const method
There doesn't seem to be a compelling reason why this method should be const
other than it was possible with the DIA implementation. The native session
is going to act as a symbol factory and cache. This could be acheived with
mutable (and the existing const_cast), but it seems cleaner to accept that
this method affects the state of the session.
This change eliminates an existing const_cast.
llvm-svn: 306041
Diffstat (limited to 'llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp')
| -rw-r--r-- | llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp b/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp index ef47b92b4f2..ef9390cda31 100644 --- a/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp +++ b/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp @@ -151,7 +151,7 @@ void DIASession::setLoadAddress(uint64_t Address) { Session->put_loadAddress(Address); } -std::unique_ptr<PDBSymbolExe> DIASession::getGlobalScope() const { +std::unique_ptr<PDBSymbolExe> DIASession::getGlobalScope() { CComPtr<IDiaSymbol> GlobalScope; if (S_OK != Session->get_globalScope(&GlobalScope)) return nullptr; |

