diff options
| author | Chris Lattner <sabre@nondot.org> | 2006-11-11 01:00:15 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2006-11-11 01:00:15 +0000 |
| commit | a0a8003f59ce9bfed2bacbac82e0218a79a855f2 (patch) | |
| tree | 7b69487e52faad3442594d1bd88268ee5b3be72e /llvm/lib/CodeGen | |
| parent | eabc15c1d8368b1c08bb47c55bfb99995ac347f4 (diff) | |
| download | bcm5719-llvm-a0a8003f59ce9bfed2bacbac82e0218a79a855f2.tar.gz bcm5719-llvm-a0a8003f59ce9bfed2bacbac82e0218a79a855f2.zip | |
disallow preinc of a frameindex. This is not profitable and causes 2-addr
pass to explode. This fixes a bunch of llc-beta failures on ppc last night.
llvm-svn: 31661
Diffstat (limited to 'llvm/lib/CodeGen')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index e3d8c80bceb..46f14b98df1 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -2750,14 +2750,20 @@ bool DAGCombiner::CombineToPreIndexedLoadStore(SDNode *N) { if (!TLI.getPreIndexedAddressParts(N, BasePtr, Offset, AM, DAG)) return false; - // Try turning it into a pre-indexed load / store except when - // 1) If N is a store and the ptr is either the same as or is a + // Try turning it into a pre-indexed load / store except when: + // 1) The base is a frame index. + // 2) If N is a store and the ptr is either the same as or is a // predecessor of the value being stored. - // 2) Another use of base ptr is a predecessor of N. If ptr is folded + // 3) Another use of base ptr is a predecessor of N. If ptr is folded // that would create a cycle. - // 3) All uses are load / store ops that use it as base ptr. + // 4) All uses are load / store ops that use it as base ptr. - // Checking #1. + // Check #1. Preinc'ing a frame index would require copying the stack pointer + // (plus the implicit offset) to a register to preinc anyway. + if (isa<FrameIndexSDNode>(BasePtr)) + return false; + + // Check #2. if (!isLoad) { SDOperand Val = cast<StoreSDNode>(N)->getValue(); if (Val == Ptr || Ptr.Val->isPredecessor(Val.Val)) |

