diff options
| author | Evan Cheng <evan.cheng@apple.com> | 2008-05-28 17:40:10 +0000 |
|---|---|---|
| committer | Evan Cheng <evan.cheng@apple.com> | 2008-05-28 17:40:10 +0000 |
| commit | 68079268f547dae09d0d39939bde439153ac1662 (patch) | |
| tree | 9139cff378eeb90d8e4cc8b010beb9ea5345dc7a /llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp | |
| parent | 427412e7c8d99b12daf9d5e1bcd65facca32aa47 (diff) | |
| download | bcm5719-llvm-68079268f547dae09d0d39939bde439153ac1662.tar.gz bcm5719-llvm-68079268f547dae09d0d39939bde439153ac1662.zip | |
Fix PR2289: vr defined by multiple implicit_def as result of coalescing.
llvm-svn: 51648
Diffstat (limited to 'llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp b/llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp index 8916d9a9c5f..ce5235c3192 100644 --- a/llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp +++ b/llvm/lib/CodeGen/SimpleRegisterCoalescing.cpp @@ -751,7 +751,7 @@ bool SimpleRegisterCoalescing::CanCoalesceWithImpDef(MachineInstr *CopyMI, /// identity copies so they will be removed. void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li, VNInfo *VNI) { - MachineInstr *ImpDef = NULL; + SmallVector<MachineInstr*, 4> ImpDefs; MachineOperand *LastUse = NULL; unsigned LastUseIdx = li_->getUseIndex(VNI->def); for (MachineRegisterInfo::reg_iterator RI = mri_->reg_begin(li.reg), @@ -761,8 +761,7 @@ void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li, ++RI; if (MO->isDef()) { if (MI->getOpcode() == TargetInstrInfo::IMPLICIT_DEF) { - assert(!ImpDef && "Multiple implicit_def defining same register?"); - ImpDef = MI; + ImpDefs.push_back(MI); } continue; } @@ -790,9 +789,13 @@ void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li, if (LastUse) LastUse->setIsKill(); else { - // Remove dead implicit_def. - li_->RemoveMachineInstrFromMaps(ImpDef); - ImpDef->eraseFromParent(); + // Remove dead implicit_def's. + while (!ImpDefs.empty()) { + MachineInstr *ImpDef = ImpDefs.back(); + ImpDefs.pop_back(); + li_->RemoveMachineInstrFromMaps(ImpDef); + ImpDef->eraseFromParent(); + } } } |

