diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-12-03 01:49:56 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2009-12-03 01:49:56 +0000 |
| commit | 8392456f1b9f24e0e1b0cc3bf3695be25367acb2 (patch) | |
| tree | 98884bd611f7c0dd613a78cc40dc09f6f5e3391e /llvm/lib/CodeGen/PostRASchedulerList.cpp | |
| parent | 65812b58f24ad51845323806e19bb4634fbad1cc (diff) | |
| download | bcm5719-llvm-8392456f1b9f24e0e1b0cc3bf3695be25367acb2.tar.gz bcm5719-llvm-8392456f1b9f24e0e1b0cc3bf3695be25367acb2.zip | |
Don't hang on to pointers or references after vector::push_back.
The MO reference to a MachineOperand can be invalidated by
MachineInstr::addOperand. Don't even use it for debugging.
llvm-svn: 90381
Diffstat (limited to 'llvm/lib/CodeGen/PostRASchedulerList.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/PostRASchedulerList.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/llvm/lib/CodeGen/PostRASchedulerList.cpp b/llvm/lib/CodeGen/PostRASchedulerList.cpp index 9101fce27a6..6995e9db1c1 100644 --- a/llvm/lib/CodeGen/PostRASchedulerList.cpp +++ b/llvm/lib/CodeGen/PostRASchedulerList.cpp @@ -510,12 +510,9 @@ void SchedulePostRATDList::FixupKills(MachineBasicBlock *MBB) { } if (MO.isKill() != kill) { - bool removed = ToggleKillFlag(MI, MO); - if (removed) { - DEBUG(errs() << "Fixed <removed> in "); - } else { - DEBUG(errs() << "Fixed " << MO << " in "); - } + DEBUG(errs() << "Fixing " << MO << " in "); + // Warning: ToggleKillFlag may invalidate MO. + ToggleKillFlag(MI, MO); DEBUG(MI->dump()); } |
