diff options
| author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2015-02-21 01:02:18 +0000 |
|---|---|---|
| committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2015-02-21 01:02:18 +0000 |
| commit | 70ab3d2af667a97523d2ab4f03b0d2f978693f47 (patch) | |
| tree | 919c0b0fac56a22397ceba0d966be3dd0aec310f /llvm/lib/AsmParser/LLLexer.cpp | |
| parent | c32f3faae9c7128dec280b8274de31400df5e704 (diff) | |
| download | bcm5719-llvm-70ab3d2af667a97523d2ab4f03b0d2f978693f47.tar.gz bcm5719-llvm-70ab3d2af667a97523d2ab4f03b0d2f978693f47.zip | |
AsmParser/Writer: Handle symbolic constants in DI 'flags:'
Parse (and write) symbolic constants in debug info `flags:` fields.
This prevents a readability (and CHECK-ability) regression with the new
debug info hierarchy.
Old (well, current) assembly, with pretty-printing:
!{!"...\\0016387", ...} ; ... [public] [rvalue reference]
Flags field without this change:
!MDDerivedType(flags: 16387, ...)
Flags field with this change:
!MDDerivedType(flags: DIFlagPublic | DIFlagRValueReference, ...)
As discussed in the review thread, this isn't a final state. Most of
these flags correspond to `DW_AT_` symbolic constants, and we might
eventually want to support arbitrary attributes in some form. However,
as it stands now, some of the flags correspond to other concepts (like
`FlagStaticMember`); until things are refactored this is the simplest
way to move forward without regressing assembly.
llvm-svn: 230111
Diffstat (limited to 'llvm/lib/AsmParser/LLLexer.cpp')
| -rw-r--r-- | llvm/lib/AsmParser/LLLexer.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/llvm/lib/AsmParser/LLLexer.cpp b/llvm/lib/AsmParser/LLLexer.cpp index 656b1692182..3bf090a4b33 100644 --- a/llvm/lib/AsmParser/LLLexer.cpp +++ b/llvm/lib/AsmParser/LLLexer.cpp @@ -241,6 +241,7 @@ lltok::Kind LLLexer::LexToken() { case ')': return lltok::rparen; case ',': return lltok::comma; case '*': return lltok::star; + case '|': return lltok::bar; } } @@ -760,6 +761,11 @@ lltok::Kind LLLexer::LexIdentifier() { DWKEYWORD(OP, DwarfOp); #undef DWKEYWORD + if (Keyword.startswith("DIFlag")) { + StrVal.assign(Keyword.begin(), Keyword.end()); + return lltok::DIFlag; + } + // Check for [us]0x[0-9A-Fa-f]+ which are Hexadecimal constant generated by // the CFE to avoid forcing it to deal with 64-bit numbers. if ((TokStart[0] == 'u' || TokStart[0] == 's') && |

