summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Analysis
diff options
context:
space:
mode:
authorDan Gohman <gohman@apple.com>2009-11-20 01:34:03 +0000
committerDan Gohman <gohman@apple.com>2009-11-20 01:34:03 +0000
commit6d919f16131690fe646ba03fa51702507acbfa1b (patch)
treee4f0df0d5ba0eed208d21a426926fd93eb4aaa43 /llvm/lib/Analysis
parentc5d28f2ea92b16c74b529a43fda7a73327b5ed28 (diff)
downloadbcm5719-llvm-6d919f16131690fe646ba03fa51702507acbfa1b.tar.gz
bcm5719-llvm-6d919f16131690fe646ba03fa51702507acbfa1b.zip
Simplify this code; it's not necessary to check isIdentifiedObject here
because if the results from getUnderlyingObject match, the values must be from the same underlying object, even if we don't know what that object is. llvm-svn: 89434
Diffstat (limited to 'llvm/lib/Analysis')
-rw-r--r--llvm/lib/Analysis/CaptureTracking.cpp12
1 files changed, 5 insertions, 7 deletions
diff --git a/llvm/lib/Analysis/CaptureTracking.cpp b/llvm/lib/Analysis/CaptureTracking.cpp
index e86ad96e4a1..1db9f2dda19 100644
--- a/llvm/lib/Analysis/CaptureTracking.cpp
+++ b/llvm/lib/Analysis/CaptureTracking.cpp
@@ -105,7 +105,7 @@ bool llvm::PointerMayBeCaptured(const Value *V,
Worklist.push_back(U);
}
break;
- case Instruction::ICmp: {
+ case Instruction::ICmp:
// Don't count comparisons of the original value against null as captures.
// This allows us to ignore comparisons of malloc results with null,
// for example.
@@ -114,16 +114,14 @@ bool llvm::PointerMayBeCaptured(const Value *V,
dyn_cast<ConstantPointerNull>(I->getOperand(1)))
if (CPN->getType()->getAddressSpace() == 0)
break;
- // Don't count comparisons of two pointers within the same identified
- // object as captures.
- Value *O0 = I->getOperand(0)->getUnderlyingObject();
- if (isIdentifiedObject(O0) &&
- O0 == I->getOperand(1)->getUnderlyingObject())
+ // Don't count comparisons of two pointers within the same object
+ // as captures.
+ if (I->getOperand(0)->getUnderlyingObject() ==
+ I->getOperand(1)->getUnderlyingObject())
break;
// Otherwise, be conservative. There are crazy ways to capture pointers
// using comparisons.
return true;
- }
default:
// Something else - be conservative and say it is captured.
return true;
OpenPOWER on IntegriCloud