diff options
| author | Ilia K <ki.stfu@gmail.com> | 2016-07-14 07:43:14 +0000 |
|---|---|---|
| committer | Ilia K <ki.stfu@gmail.com> | 2016-07-14 07:43:14 +0000 |
| commit | beb1aa907d6ff298c860c3ab571017c81321766e (patch) | |
| tree | 30e60c107937c189bc1261d62deb9eef3532a370 /lldb/tools/lldb-mi/MICmdCmdBreak.cpp | |
| parent | 666aa945a540931451f82cd5e471bc969b1f87bc (diff) | |
| download | bcm5719-llvm-beb1aa907d6ff298c860c3ab571017c81321766e.tar.gz bcm5719-llvm-beb1aa907d6ff298c860c3ab571017c81321766e.zip | |
Fix -break-enable/-break-disable commands (MI)
* Previously -break-enable mistakenly set BP's enabled flag to false.
* These commands print fake =breakpoint-modified messages, what's not
needed anymore because that events are come in normal way.
* Add tests for -break-enable/-break-disable commands
Initial patch from xuefangliang@hotmail.com. The test case was improved by me.
Differential Revision: http://reviews.llvm.org/D21757
llvm-svn: 275381
Diffstat (limited to 'lldb/tools/lldb-mi/MICmdCmdBreak.cpp')
| -rw-r--r-- | lldb/tools/lldb-mi/MICmdCmdBreak.cpp | 26 |
1 files changed, 3 insertions, 23 deletions
diff --git a/lldb/tools/lldb-mi/MICmdCmdBreak.cpp b/lldb/tools/lldb-mi/MICmdCmdBreak.cpp index e758a3dccce..7238200dfca 100644 --- a/lldb/tools/lldb-mi/MICmdCmdBreak.cpp +++ b/lldb/tools/lldb-mi/MICmdCmdBreak.cpp @@ -568,19 +568,9 @@ CMICmdCmdBreakDisable::Acknowledge() { if (m_bBrkPtDisabledOk) { - const CMICmnMIValueConst miValueConst(CMIUtilString::Format("%d", m_nBrkPtId)); - const CMICmnMIValueResult miValueResult("number", miValueConst); - CMICmnMIValueTuple miValueTuple(miValueResult); - const CMICmnMIValueConst miValueConst2("n"); - const CMICmnMIValueResult miValueResult2("enabled", miValueConst2); - miValueTuple.Add(miValueResult2); - const CMICmnMIValueResult miValueResult3("bkpt", miValueTuple); - const CMICmnMIOutOfBandRecord miOutOfBandRecord(CMICmnMIOutOfBandRecord::eOutOfBand_BreakPointModified, miValueResult3); - bool bOk = CMICmnStreamStdout::TextToStdout(miOutOfBandRecord.GetString()); - const CMICmnMIResultRecord miRecordResult(m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Done); m_miResultRecord = miRecordResult; - return bOk; + return MIstatus::success; } const CMIUtilString strBrkPtId(CMIUtilString::Format("%d", m_nBrkPtId)); @@ -683,7 +673,7 @@ CMICmdCmdBreakEnable::Execute() if (brkPt.IsValid()) { m_bBrkPtEnabledOk = true; - brkPt.SetEnabled(false); + brkPt.SetEnabled(true); m_nBrkPtId = nBrk; } @@ -704,19 +694,9 @@ CMICmdCmdBreakEnable::Acknowledge() { if (m_bBrkPtEnabledOk) { - const CMICmnMIValueConst miValueConst(CMIUtilString::Format("%d", m_nBrkPtId)); - const CMICmnMIValueResult miValueResult("number", miValueConst); - CMICmnMIValueTuple miValueTuple(miValueResult); - const CMICmnMIValueConst miValueConst2("y"); - const CMICmnMIValueResult miValueResult2("enabled", miValueConst2); - miValueTuple.Add(miValueResult2); - const CMICmnMIValueResult miValueResult3("bkpt", miValueTuple); - const CMICmnMIOutOfBandRecord miOutOfBandRecord(CMICmnMIOutOfBandRecord::eOutOfBand_BreakPointModified, miValueResult3); - bool bOk = CMICmnStreamStdout::TextToStdout(miOutOfBandRecord.GetString()); - const CMICmnMIResultRecord miRecordResult(m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Done); m_miResultRecord = miRecordResult; - return bOk; + return MIstatus::success; } const CMIUtilString strBrkPtId(CMIUtilString::Format("%d", m_nBrkPtId)); |

